Repository navigation

[Bug]: --proxy-domain does not proxy when the host includes a port #8128

adityajai119 · 2026-11-13T04:55:12Z

### Is there an existing issue for this? - [x] I have searched the existing issues ### OS/Web Information - Web Browser: not needed, reproduced with the unit tests - Local OS: Windows 11 - Remote OS: Windows 11 - Remote Architecture: x64 - `code-server --version`: `main` at dda09f2 ### Steps to Reproduce 1. Start code-server with `--proxy-domain example.com`, with `*.example.com` pointing at it, and run an app on port 3000. 2. Open `http://3000.example.com:8080/`, that is, with code-server on a port other than 80 or 443. The same happens behind a reverse proxy that sends the host with a port, for example NGINX with `proxy_set_header X-Forwarded-Host $host:$server_port;` (as in #6166). ### Expected The request is proxied to port 3000, the same as `3000.example.com` without a port, and as it was before 4.14.0. ### Actual The request is not proxied. code-server handles it itself, so the browser gets code-server or its login page instead of the app. From the unit test setup on `main` (dda09f2), with `--auth=none --proxy-domain=example.com` and an app on port `PORT` that answers `/wsup` with `"proxied"`: ``` GET /wsup Host: PORT.example.com -> 200 "proxied" GET /wsup Host: PORT.example.com:8443 -> 500 from code-server's own routes (the test setup cannot load VS Code) ``` Since #6225, `maybeProxy()` in `src/node/routes/domainProxy.ts` matches the host from `getHost()`, which keeps the port, against a pattern anchored at the end, `^(\d+)\.example\.com$`. Before #6225 it dropped the port from the host first. `getCookieDomain()` in `src/node/http.ts` still drops the port when it compares the host with the proxy domains. #7194 ran into this and worked around it by adding the port to the proxy domain (`PROXY_DOMAIN=example.com:12345`). ### Logs Not applicable. ### Screenshot/Video _No response_ ### Does this bug reproduce in native VS Code? This cannot be tested in native VS Code ### Does this bug reproduce in VS Code web? This cannot be tested in VS Code web ### Does this bug reproduce in GitHub Codespaces? This cannot be tested in GitHub Codespaces ### Are you accessing code-server over a secure context? - [ ] I am using a secure context. ### Notes The fix is to let the proxy domain pattern match an optional `:port` at the end of the host. Proxy domains that already include a port, like the workaround in #7194, keep working. I am opening a PR with the fix and a test. AI-assisted: found and reproduced with an AI coding agent; the check above was run locally.

New issue

Open

#8129