Skip to content

dataconnect(change): merge "X-Client-Platform" header into "X-Client-Version" - #8495

Merged
dconeybe merged 2 commits into
mainfrom
dconeybe/dataconnect/CloudMonitoringHeaders2
Jul 30, 2026
Merged

dconeybe merged 2 commits into
mainfrom
dconeybe/dataconnect/CloudMonitoringHeaders2

Conversation

@dconeybe

@dconeybe dconeybe commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

This PR updates the gRPC metadata in firebase-dataconnect by merging the X-Client-Platform header into the X-Client-Version header (formatting as android/<version>) and removing the standalone X-Client-Platform header.

This is an update to PR #8486 which was merged yesterday and added both of these headers. This update was made to accommodate the firebase-js-sdk because the "X-Client-Platform" header causes the CORS OPTIONS preflight request to fail with a 403 "Permission Denied" error due to that header being absent from Google's list of whitelisted CORS headers. See firebase/firebase-js-sdk#10217 for a few more details, if interested.

Highlights

  • Header Consolidation: Merged the platform identifier into the X-Client-Version header (e.g. android/<version>) and removed the separate X-Client-Platform (x-client-platform) header.
  • Test Updates: Updated integration and unit test suites to verify the new X-Client-Version header value format.
Changelog
  • CHANGELOG.md
  • DataConnectGrpcMetadata.kt
    • Removed the x-client-platform header definition and updated x-client-version to format as android/$dataConnectSdkVersion.
  • GrpcMetadataIntegrationTest.kt
    • Removed test assertions for x-client-platform and updated x-client-version assertions to expect android/${BuildConfig.VERSION_NAME}.
  • DataConnectGrpcMetadataUnitTest.kt
    • Removed x-client-platform test cases and updated x-client-version test cases to verify the new header format.
  • DataConnectGrpcRPCsUnitTest.kt
    • Removed test cases for x-client-platform and updated x-client-version assertions for executeQuery, executeMutation, and connect.

…Client-Version" [skip actions]

This is an update to PR #8486
which was merged yesterday and added both of these headers.

This change was made to accommodate the firebase-js-sdk because the
"X-Client-Platform" header causes the CORS OPTIONS preflight request to
fail with a 403 "Permission Denied" error due to that header being
absent from Google's list of whitelisted CORS headers.

See firebase/firebase-js-sdk#10217 for a few
more details, if interested.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@github-actions

Copy link
Copy Markdown
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@dconeybe
dconeybe merged commit 7bc5991 into main Jul 30, 2026
49 checks passed
@dconeybe
dconeybe deleted the dconeybe/dataconnect/CloudMonitoringHeaders2 branch July 30, 2026 16:28
@github-actions github-actions Bot mentioned this pull request Jul 31, 2026
@firebase firebase locked and limited conversation to collaborators Aug 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants