Skip to content

fix: require Protobuf 6.33.5+ - #17743

Merged
parthea merged 1 commit into
mainfrom
require-protobuf-6-33-5
Jul 30, 2026
Merged

fix: require Protobuf 6.33.5+#17743
parthea merged 1 commit into
mainfrom
require-protobuf-6-33-5

Conversation

@parthea

@parthea parthea commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Towards b/420641246

This PR is similar to #17349 for the generator/auto-generated code.

The minimum versions of google-api-core and proto-plus and others also need to be versions that support Protobuf 6
https://github.com/googleapis/python-api-core/releases/tag/v2.24.2
https://github.com/googleapis/proto-plus-python/releases/tag/v1.26.1

Also see the client library versions which allow Protobuf 6.x in PR #13644 (https://github.com/googleapis/google-cloud-python/blob/release-please--branches--main--release-notes/release-notes.md)

Once this PR is merged, I will update protoc here to 33.5 so we can update gencode: https://github.com/googleapis/librarian/blob/fa34184d746948b1da7df000ffcf832979a3c488/cmd/librarian/Dockerfile#L49

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 16, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum protobuf version requirement to 6.33.5 across multiple packages and configuration files. It also removes support for the 'cpp' protobuf implementation and cleans up associated test configurations and legacy logic. A review comment suggests removing a redundant parameterized test case in packages/google-api-core/noxfile.py to improve code cleanliness.

Comment thread packages/google-api-core/noxfile.py Outdated
@parthea parthea self-assigned this Jul 17, 2026
@parthea
parthea force-pushed the require-protobuf-6-33-5 branch from e13937b to a007839 Compare July 17, 2026 18:00