fix!: native state issues on Android when multiple engines are used - #525
Merged
Merged
Conversation
…gleton on Android
jokerttu
marked this pull request as ready for review
November 14, 2025 11:29
jokerttu
force-pushed
the
refactor/session-manager-lifecycle-architecture
branch
2 times, most recently
from
November 14, 2025 14:18
a680664 to
dbe63bd
Compare
jokerttu
force-pushed
the
refactor/session-manager-lifecycle-architecture
branch
from
November 17, 2025 10:11
dbe63bd to
f146116
Compare
illuminati1911
approved these changes
Nov 19, 2025
illuminati1911
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Tests are bit unstable though but I don't think it's related to this PR.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes how navigation instances an navigation manager instances are handled when multiple flutter engines are used for example when foreground services are used.
This change will allow multiple engine intances to communicate with navigation sessions.
Fixes #308
Closes #169
Related #211
Related #274
Related #397
Pre-launch Checklist