Skip to content

fix(ci): Remove submodule once and for all - #15495

Merged
chaudum merged 2 commits into
mainfrom
chaudum/remove-submodule
Dec 19, 2024
Merged

chaudum merged 2 commits into
mainfrom
chaudum/remove-submodule

Conversation

@chaudum

@chaudum chaudum commented Dec 19, 2024

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Removes the workflow submodule added by the GH action for Helm chart release and add the path to the gitignore file.

The GH workflow for releasing the Helm chart adds the submodule.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
So future runs of `act` when releasing the Helm chart does not add it
to the repo.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum
chaudum requested a review from a team as a code owner December 19, 2024 10:06

@ashwanthgoli ashwanthgoli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaudum
chaudum merged commit 80e8e60 into main Dec 19, 2024
@chaudum
chaudum deleted the chaudum/remove-submodule branch December 19, 2024 10:14
mveitas pushed a commit to mveitas/loki that referenced this pull request Jan 6, 2025
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
felix0102 pushed a commit to felix0102/loki that referenced this pull request Aug 2, 2026
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants