Skip to content

feat(outputs.remotefile): Add compression for remotefile plugin - #17409

Merged
srebhan merged 3 commits into
influxdata:masterfrom
neelayu:compress-remote-file
Oct 20, 2025
Merged

feat(outputs.remotefile): Add compression for remotefile plugin#17409
srebhan merged 3 commits into
influxdata:masterfrom
neelayu:compress-remote-file

Conversation

@neelayu

@neelayu neelayu commented Jul 30, 2025

Copy link
Copy Markdown
Contributor

Summary

Adds support for compression in remotefile output plugin

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #17376

@telegraf-tiger telegraf-tiger Bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Jul 30, 2025
mstrandboge
mstrandboge reviewed Aug 4, 2025
View reviewed changes
Comment thread plugins/outputs/remotefile/README.md
Comment thread plugins/outputs/remotefile/remotefile_test.go
@mstrandboge mstrandboge self-assigned this Aug 4, 2025
@mstrandboge

mstrandboge commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

@neelayu Are there any updates on this?

@mstrandboge mstrandboge added the waiting for response waiting for response from contributor label Sep 4, 2025
@neelayu

neelayu commented Sep 5, 2025

Copy link
Copy Markdown
Contributor Author

@mstrandboge As mentioned in the comment, I have taken the code and readme sections from existing outputs.file plugin. Can you suggest what needs to change? thanks!

@telegraf-tiger telegraf-tiger Bot removed the waiting for response waiting for response from contributor label Sep 5, 2025
mstrandboge
mstrandboge approved these changes Oct 14, 2025
View reviewed changes

@mstrandboge mstrandboge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarification and sorry for the delay!

@mstrandboge mstrandboge assigned skartikey and srebhan and unassigned mstrandboge Oct 14, 2025
@mstrandboge mstrandboge added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 14, 2025
srebhan
srebhan reviewed Oct 15, 2025
View reviewed changes

@srebhan srebhan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neelayu! Two small comments from my side...

Comment thread plugins/outputs/remotefile/remotefile.go Outdated
Comment thread plugins/outputs/remotefile/remotefile.go Outdated
@neelayu
neelayu force-pushed the compress-remote-file branch from 1d526eb to 945f36a Compare October 15, 2025 11:03
@neelayu
neelayu force-pushed the compress-remote-file branch from 945f36a to 0d36c04 Compare October 15, 2025 11:12
@telegraf-tiger

telegraf-tiger Bot commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

. DEB . RPM . TAR . GZ . ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan approved these changes Oct 20, 2025
View reviewed changes

@srebhan srebhan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neelayu!

@srebhan
srebhan merged commit c6b5b6c into influxdata:master Oct 20, 2025
27 checks passed
@github-actions github-actions Bot added this to the v1.37.0 milestone Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srebhan srebhan srebhan approved these changes
+1 more reviewer
@mstrandboge mstrandboge mstrandboge approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@srebhan srebhan

Labels

feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Milestone

v1.37.0

Development

Successfully merging this pull request may close these issues.

Add Compression Support to the RemoteFile Output Plugin for Telegraf

4 participants

@neelayu @mstrandboge @srebhan @skartikey