Activity for Lensfun

Peter Stephens posted a comment on ticket #156

Peter Stephens — Mon, 22 Apr 2019 23:51:41 -0000

My telephoto kit lens is not marked as VR. The 18-55 mm lens is marked as VR capable. On Sun, Apr 14, 2019, 11:22 PM Peter Stephens hzqmrk2@users.sourceforge.net wrote: [features:#156] Nikon D3500 and Kit lens* Status: open Labels: Nikon Created: Mon Apr 15, 2019 03:22 AM UTC by Peter Stephens Last Updated: Mon Apr 15, 2019 03:22 AM UTC Owner: Torsten Bronger Attachments: 0001-Added-D3500-to-slr-nikkor.xml-.-Note-that-I-assumed-.patch https://sourceforge.net/p/lensfun/features/156/attachment/0001-Added-D3500-to-slr-nikkor.xml-.-Note-that-I-assumed-.patch...

Torsten Bronger modified ticket #108

Torsten Bronger — Mon, 22 Apr 2019 05:18:27 -0000

Vignetting with Canon PowerShot G1X Mark II at 12.5mm focal length

Torsten Bronger posted a comment on ticket #108

Torsten Bronger — Mon, 22 Apr 2019 05:18:05 -0000

Or, you collect the upload ID where you observed this in a GitHub issue.

junkyardsparkle posted a comment on ticket #108

junkyardsparkle — Sun, 21 Apr 2019 20:59:38 -0000

Not from me, unless it's worth keeping open a little longer as a reminder to actually add the crop tags to the profiles that need them... otherwise, I could add FIXME comments to the profiles, for the ones I can remember having this "feature"...

junkyardsparkle posted a comment on ticket #108

junkyardsparkle — Sun, 21 Apr 2019 20:52:59 -0000

That's interesting, I've seen several cases similar to this one where maximal_radius would be useful. I did try the element, but it didn't seem to have any effect in darktable, at least. Implementing it as you describe sounds good to me, but I guess should be discussed somewhere. It might be best if there was still a way to get the current "all-the-pixels" behavior if it's desired.

Richard Hutchings posted a comment on ticket #153

Richard Hutchings — Sun, 21 Apr 2019 17:37:31 -0000

I found the profile in the list after I posted this. No further action needed . On Sun, Apr 21, 2019, 10:27 AM Torsten Bronger bronger@users.sourceforge.net wrote: status: open --> wont-fix assigned_to: Torsten Bronger Comment: We need calibration images for fulfilling such a request. Please see https://wilson.bronger.org/calibration. [features:#153] https://sourceforge.net/p/lensfun/features/153/ Canon SX30is* Status: wont-fix Created: Wed Mar 13, 2019 11:28 AM UTC by Richard Hutchings Last Updated:...

Torsten Bronger modified ticket #157

Torsten Bronger — Sun, 21 Apr 2019 15:09:44 -0000

Nikon Z6, Z7 and Lens 24-70 f/4.0 S

Torsten Bronger posted a comment on ticket #157

Torsten Bronger — Sun, 21 Apr 2019 15:09:44 -0000

I included your data. If possible, still tell me the camera used. Thank you for the contribution!

Torsten Bronger posted a comment on ticket #157

Torsten Bronger — Sun, 21 Apr 2019 15:07:46 -0000

Which camera was used for the calibration? Z6 or Z7?

Torsten Bronger modified ticket #156

Torsten Bronger — Sun, 21 Apr 2019 14:52:21 -0000

Nikon D3500 and Kit lens

Torsten Bronger posted a comment on ticket #156

Torsten Bronger — Sun, 21 Apr 2019 14:52:21 -0000

I clode this ticket – the data is in Lensfun thanks to another contributor. However, I’m still curious about the “VR” thing.

Torsten Bronger posted a comment on ticket #156

Torsten Bronger — Sun, 21 Apr 2019 14:50:45 -0000

Why do you remove the “VR”?

Torsten Bronger posted a comment on ticket #156

Torsten Bronger — Sun, 21 Apr 2019 14:37:10 -0000

Have you also submitted the data that came from freddie@w…?

Torsten Bronger modified ticket #154

Torsten Bronger — Sun, 21 Apr 2019 14:28:49 -0000

RX100 VI lens

Torsten Bronger modified ticket #153

Torsten Bronger — Sun, 21 Apr 2019 14:27:41 -0000

Canon SX30is

Torsten Bronger posted a comment on ticket #153

Torsten Bronger — Sun, 21 Apr 2019 14:27:41 -0000

We need calibration images for fulfilling such a request. Please see https://wilson.bronger.org/calibration.

Torsten Bronger modified ticket #152

Torsten Bronger — Sun, 21 Apr 2019 14:26:50 -0000

missing lens:TAMRON 100-400mm/F4.5-6.3 Di VC USD A035

Torsten Bronger posted a comment on ticket #152

Torsten Bronger — Sun, 21 Apr 2019 14:26:50 -0000

Calibration data for this lens has been uploaded here: https://github.com/lensfun/lensfun/issues/550. Please follow progress there.

Torsten Bronger modified ticket #150

Torsten Bronger — Sun, 21 Apr 2019 14:24:25 -0000

Canon EF 28mm f/2.8 IS ISM

Torsten Bronger posted a comment on ticket #150

Torsten Bronger — Sun, 21 Apr 2019 14:24:25 -0000

This is explained at https://wilson.bronger.org/calibration.

Torsten Bronger modified ticket #143

Torsten Bronger — Sun, 21 Apr 2019 14:23:51 -0000

Please add support for Canon EOS M6

Torsten Bronger posted a comment on ticket #143

Torsten Bronger — Sun, 21 Apr 2019 14:23:34 -0000

The M6 has been included. As for the lenses, calibration images form them need to be uploaded at https://wilson.bronger.org/calibration.

Torsten Bronger modified ticket #142

Torsten Bronger — Sun, 21 Apr 2019 14:22:29 -0000

Lens profile: Mitakon Zhongyi Speedmaster 35mm f/0.95 Mark II

Torsten Bronger posted a comment on ticket #142

Torsten Bronger — Sun, 21 Apr 2019 14:22:29 -0000

I’m sorry to say that LCP files cannot be converted into Lensfun’s data format, and thus not included into the database distributed with it. However, you can use them with cutting-edge Lensfun versions.

Torsten Bronger modified ticket #138

Torsten Bronger — Sun, 21 Apr 2019 14:20:02 -0000

Vignetting data for Sony SEL2470GM

Torsten Bronger modified ticket #137

Torsten Bronger — Sun, 21 Apr 2019 14:19:25 -0000

Calibration data for Huawei P20 Pro

Torsten Bronger modified ticket #127

Torsten Bronger — Sun, 21 Apr 2019 14:16:44 -0000

Zeiss, Fuji, Canon, and Sigma distortion correction info

Torsten Bronger posted a comment on ticket #127

Torsten Bronger — Sun, 21 Apr 2019 14:16:02 -0000

@robert: Please provide further information so that we can include your data: Which camera was used? A 6D Mark I cannot be used for Touit or XF mount lenses. As junkyardsparkle has already pointed out, there must be only one cropfactor per calibration. Besides, cropfactor “1” for an XF lens is probably incorrect. So, which cropfactor was used for Touit 1.8/32 Touit 2.8/12 Fujifilm XF80mmF2.8 Thank you!

Torsten Bronger modified ticket #86

Torsten Bronger — Sun, 21 Apr 2019 13:42:39 -0000

Lensfun compile instructions

Torsten Bronger posted a comment on ticket #86

Torsten Bronger — Sun, 21 Apr 2019 13:42:26 -0000

Thinking about this again, I think I experienced the same problem but solved it by creating the symbolic links manually and didn’t bother further. I added a comment to the docs (commit 41252526).

Torsten Bronger modified ticket #12

Torsten Bronger — Sun, 21 Apr 2019 13:27:21 -0000

Make Python scripts working on non-Unices

Torsten Bronger posted a comment on ticket #12

Torsten Bronger — Sun, 21 Apr 2019 13:27:21 -0000

Closed because older than a year, nobody working on this I don’t know what is the exact problem, or if there is one at all anymore

seebk modified ticket #117

seebk — Sun, 21 Apr 2019 10:17:43 -0000

Some C API functions not exported on Windows

seebk posted a comment on ticket #117

seebk — Sun, 21 Apr 2019 10:17:25 -0000

Yes, we can close this. Discussion can continue in the respective GitHub issue about the C-Wrapper: https://github.com/lensfun/lensfun/issues/502

Torsten Bronger posted a comment on ticket #108

Torsten Bronger — Sun, 21 Apr 2019 09:21:14 -0000

Any objection to closing this?

Torsten Bronger posted a comment on ticket #108

Torsten Bronger — Sun, 21 Apr 2019 09:20:34 -0000

As a side node, calibrate.py has the – I think undocumented – feature of having a sidecar file for each vignetting RAW which contains the line maximal_radius: 0.7. “0.7” means 70% of the image diagonal are usable. Then, farther points are not considered for the vignetting measurement, and the resulting polynomial is much better (in the useful area). Of course, it is bad that it is not documented, and that it does not create a element.

Torsten Bronger posted a comment on ticket #117

Torsten Bronger — Sun, 21 Apr 2019 09:05:13 -0000

So, this one can be closed, and the remaining things are tracked elsewhere?

Torsten Bronger modified a comment on ticket #108

Torsten Bronger — Sun, 21 Apr 2019 09:01:44 -0000

Ah! My bad … the RAW image viewer I used apparently showed the embedded JPEG. There is the element: http://lensfun.sourceforge.net/manual/v0.3.2/elem_calibration.html But it has never been used in the DB, and I don’t know whether the code uses it. But it is exactly for this purpose. We could make use of it in the “autoscale” function. This would be used by Darktable, too, without them needing to change the code.

Torsten Bronger posted a comment on ticket #108

Torsten Bronger — Sun, 21 Apr 2019 09:01:11 -0000

junkyardsparkle modified a comment on ticket #108

junkyardsparkle — Sat, 20 Apr 2019 21:01:11 -0000

The problem isn't that the in-camera cropping affects the lensfun corrections, it's that Lensfun/darktable doesn't do the additional cropping that the camera does in order to hide the edges of the image circle in the corners. You can see this best on the second linked image (YIMG_0026.CR2)... with default correction in darktable there are still visible traces of the physical edge of the image circle, most easily noticed in the lower left. You can, of course, adjust this for each image in darktable...

junkyardsparkle modified a comment on ticket #108

junkyardsparkle — Sat, 20 Apr 2019 21:00:15 -0000

junkyardsparkle posted a comment on ticket #108

junkyardsparkle — Sat, 20 Apr 2019 20:59:04 -0000

The problem isn't that the in-camera cropping affects the lensfun corrections, it's that Lensfun/darktable doesn't do the additional cropping that the camera does in order to hide the edges of the image circle in the corners. You can see this best on the second linked image (YIMG_0026.CR2)... with default correction in darktable there are still visible traces of the physical edge of the image circle, most easily notices in the lower left. You can, of course, adjust this for each image in darktable...

seebk posted a comment on ticket #117

seebk — Sat, 20 Apr 2019 20:20:22 -0000

The declaration in the header file was slightly different to the definition in the source file. I think this is already fixed for lf_db_read_timestamp(). The implementation of lf_mount_copy() is missing. The lf_db_save and load functions have to be adapted the new lfDatabase class API. The concept of the load and save functions with its respective overloads is still a bit messy, though.

Torsten Bronger posted a comment on ticket #72

Torsten Bronger — Sat, 20 Apr 2019 19:05:52 -0000

Can this be closed?

Torsten Bronger modified ticket #78

Torsten Bronger — Sat, 20 Apr 2019 18:55:36 -0000

Handle two vignetting sets per lens.

Torsten Bronger posted a comment on ticket #78

Torsten Bronger — Sat, 20 Apr 2019 18:55:24 -0000

I leave it as it is: Lensfun’s corrections always apply to the rawest possible image data to get from a certain camera.

Torsten Bronger posted a comment on ticket #69

Torsten Bronger — Sat, 20 Apr 2019 18:50:04 -0000

How can we proceed here? We could just apply the patch (thanks for that) but Python3.5 will be out of date, as any other Python version. Can we add a note to adjust the Python version, or is there a general solution?

Torsten Bronger modified ticket #85

Torsten Bronger — Sat, 20 Apr 2019 18:39:41 -0000

Pentax-DA 18-135mm recognition

Torsten Bronger modified ticket #85

Torsten Bronger — Sat, 20 Apr 2019 18:37:10 -0000

Pentax-DA 18-135mm recognition

Torsten Bronger modified ticket #86

Torsten Bronger — Sat, 20 Apr 2019 18:36:01 -0000

Lens names

Torsten Bronger modified ticket #87

Torsten Bronger — Sat, 20 Apr 2019 18:32:04 -0000

Wrong Maker name for pentax model cameras

Torsten Bronger modified ticket #91

Torsten Bronger — Sat, 20 Apr 2019 18:00:01 -0000

Fixed lenses RX10 and RX100M2 not autocorrected

Torsten Bronger posted a comment on ticket #108

Torsten Bronger — Sat, 20 Apr 2019 11:35:26 -0000

I don’t really understand what we are talking about here. Frankly, I don’t see any vignetting on those shots. :-/ They are not really suitable to estimate vignetting anyway. @junkyardsparke: The cropping of the camera should not affect Lensfun’s corrections, as long as the crop factor is correctly assumed. If it is off by the same amount that at the calibration, it should not affect either.

Torsten Bronger modified ticket #110

Torsten Bronger — Sat, 20 Apr 2019 11:26:28 -0000

Error when updating database

Torsten Bronger posted a comment on ticket #110

Torsten Bronger — Sat, 20 Apr 2019 11:26:09 -0000

Maybe the TLS certificate at wilson.bronger.org was invalid at that point in time? Anyway, it is valid now, and should be renewed automatically. (Certbot.)

Torsten Bronger posted a comment on ticket #113

Torsten Bronger — Sat, 20 Apr 2019 09:52:32 -0000

I did those calibrations myself back in 2012 because I own those lenses. I had a look at my old images – the correction in Darktable is perfect. Thus, there are three possible explanations: My method with the diffuser plate was suboptimal In-camera vignetting correction is on, resulting in double correction There is some lens model variance, i.e. lens samples differ from each other slightly The second point can be excluded easily: Just assure that in-camera vignetting correction is off. At least...

Torsten Bronger posted a comment on ticket #117

Torsten Bronger — Sat, 20 Apr 2019 09:26:23 -0000

What exactly does not match (a branch in the definition of LF_EXPORT?)