Closed Bug 1987440 Opened 1 year ago Closed 1 year ago

Dialog code clean up

Categories

(Core :: DOM: Core & HTML, task, P5)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
145 Branch
Tracking Flags:
Tracking Status
firefox145 --- fixed

People

(Reporter: keithamus, Assigned: keithamus)

References

(
URL
)

Details

Attachments

(1 file)

Bug 1987440 - Tidy up HTMLDialogElement.cpp r=smaug,dom-core
48 bytes, text/x-phabricator-request
Details | Review

The dialog code has fallen out of sync with the defined terms in the HTML spec. While behaviour is consistent with the spec for users, we should tidy the code so that it better reflects the specification prose.

This mostly adds code comments, slightly reorganises some code (in
non-user impacting ways) and removes some TODOs which are now done.

Pushed by sstanca@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/f01d101e1c1e https://hg.mozilla.org/integration/autoland/rev/5562ebb2b4c0 Revert "Bug 1987440 - Tidy up HTMLDialogElement.cpp r=smaug,dom-core" for causing wpt failures.

Reverted this because it was causing wpt failures.

  • Revert link
  • Push with failures
  • Failure Log
  • Failure line: PROCESS-CRASH | MOZ_ASSERT(mCloseWatcher) [@ mozilla::dom::HTMLDialogElement::SetCloseWatcherEnabledState] | /html/semantics/interactive-elements/the-dialog-element/dialog-closedby-bounds-clicking.html

Also, please check these wpt failures.

Flags: needinfo?(mozilla)
Flags: needinfo?(mozilla)