Closed Bug 2064333 Opened 1 month ago Closed 29 days ago

Enable scoped registries in nightly

Categories

(Core :: DOM: Core & HTML, task)

task

Tracking

()

RESOLVED FIXED
156 Branch
Tracking Status
relnote-firefox --- nightly+
firefox156 --- fixed

People

(Reporter: keithamus, Assigned: keithamus)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

No description provided.

This should be mentioned in the Nightly release notes. Keith, could you please make a relnote request?

Sebastian

Flags: needinfo?(mozilla)
Keywords: dev-doc-needed

Release Note Request (optional, but appreciated)
[Why is this notable]: Enable Scoped Custom Element Registries in Nightly
[Affects Firefox for Android]: Yes
[Suggested wording]: Enable Scoped Custom Element Registries in Nightly
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/API/CustomElementRegistry/CustomElementRegistry

relnote-firefox: --- → ?
Flags: needinfo?(mozilla)
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Pushed by sstanca@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/f83dfa010316 https://hg.mozilla.org/integration/autoland/rev/4c9cf8a24c56 Revert "Bug 2064333 - Turn scoped registries on for nightly builds r=dom-core-reviewers,smaug" for causing devtools failures in browser_webconsole_object_inspector_entries.js.

Reverted this because it was causing devtools failures in browser_webconsole_object_inspector_entries.js.

L.E. Please also check these wpt failures and these ones.

Flags: needinfo?(mozilla)
Flags: needinfo?(mozilla)

(In reply to Keith Cirkel [:keithamus] from comment #2)

[Suggested wording]: Enable Scoped Custom Element Registries in Nightly

I think the wording can be improved a bit. Maybe something like this (borrowing from the Interop 2026 description of that feature):

Starting with Firefox 156, Firefox Nightly supports Scoped Custom Element Registries. Those registries can be created using the CustomElementRegistry() constructor that are separate from the global window.customElements registry. Creating more than one registry is useful for multiple custom elements that have the same tag name to coexist.

Sebastian

(In reply to Sebastian Zartner [:sebo] from comment #7)

(In reply to Keith Cirkel [:keithamus] from comment #2)

[Suggested wording]: Enable Scoped Custom Element Registries in Nightly

I think the wording can be improved a bit. Maybe something like this (borrowing from the Interop 2026 description of that feature):

Starting with Firefox 156, Firefox Nightly supports Scoped Custom Element Registries. Those registries can be created using the CustomElementRegistry() constructor that are separate from the global window.customElements registry. Creating more than one registry is useful for multiple custom elements that have the same tag name to coexist.

Sebastian

Thanks Sebastian, that wording is much better.

Pushed by kcirkel@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/a173c556f3e0 https://hg.mozilla.org/integration/autoland/rev/b9d9dd337871 Turn scoped registries on for nightly builds r=dom-core-reviewers,smaug,devtools-reviewers,ochameau
Pushed by rperta@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/1812c216a7c4 https://hg.mozilla.org/integration/autoland/rev/1566d693834f Revert "Bug 2064333 - Turn scoped registries on for nightly builds r=dom-core-reviewers,smaug,devtools-reviewers,ochameau" for causing unexpected ok wpt failures at sanitizer-custom-elements-constructor.html

Backed out for causing unexpected ok wpt failures at sanitizer-custom-elements-constructor.html
Backout link
Push with failures
Failure log(s)
Failure line: TEST-UNEXPECTED-OK | /sanitizer-api/sanitizer-custom-elements-constructor.html | expected ERROR

Flags: needinfo?(mozilla)
Pushed by kcirkel@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/ad08825ff180 https://hg.mozilla.org/integration/autoland/rev/b6e83b8a54d3 Turn scoped registries on for nightly builds r=dom-core-reviewers,smaug,devtools-reviewers,ochameau
Status: ASSIGNED → RESOLVED
Closed: 29 days ago
Resolution: --- → FIXED
Target Milestone: --- → 156 Branch
Flags: needinfo?(mozilla)

Thanks, added to the Fx156 nightly release notes, please allow 30 minutes for the site to update.
The nightly-only note will be removed after three cycles or when it is enabled by default, whichever comes earlier.

Regressions: 2065539
QA Whiteboard: [qa-triage-done-c157/b156]

FF156 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/45434

FYI Donal, a better link for docs is probably https://developer.mozilla.org/en-US/docs/Web/API/Web_components/Using_custom_elements#scoped_custom_element_registries - added a request for info, but that's just so you get notified of this.

Flags: needinfo?(dmeehan)

Release note updated

Flags: needinfo?(dmeehan)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: