Repository navigation
Fix corner radius for Glance app widget background - #101
Closed
valentinilk wants to merge 1 commit into
Closed
valentinilk wants to merge 1 commit into
valentinilk wants to merge 1 commit into
Conversation
Closed
liu-wanshun
approved these changes
Oct 9, 2023
Contributor
|
Hi! Thanks for your PR, apply the following patch to your code to fix the glance corner radius and I will merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
cornerRadiusmodifiers included inappWidgetBackgroundCornerRadius()andappWidgetInnerCornerRadius()where actually never applied to the widget. TheCombinedGlanceModifiercreated by thecornerRadiusfunctions was only ever created, but was never be made part of the modifier chain.This can be seen by comparing the Glance widget (bottom) to the legacy one (on top), where the system's radius is applied correctly:

After the fix it will look like this:

Unfortunately the fix reveals a bug in Glance. If you select the widget by using a long press, you can see that the system still thinks that the smaller radius is applied. The small radius is probably the fallback radius of 16 dp.
I'll wait with the bug report until this PR is merged, so I can provide this project as a sample.