Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a mechanism to account for locale ID and locale data in the shared output hash when inlining translations and polyfills are empty, appending a hash footer to the polyfills bundle. It also moves the caching of loaded locale data from the utility module to the worker level and updates E2E tests to verify cacheability under esbuild. The review feedback suggests passing options.workspaceRoot to loadLocaleData to ensure robust module resolution in monorepos.
splincode
force-pushed
the
fix/i18n-stable-generated-polyfills
branch
from
November 14, 2026 19:05
a682c99 to
3d6dbd3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
In a localized AOT build without additional polyfills, the CLI-generated polyfills bundle only sets the locale and loads Angular locale data. Editing an application translation still changes its URL because esbuild includes the translation-file digest in the filename hash.
Part of #30675; follows the feedback on #34673.
What is the new behavior?
Use the selected locales and their Angular locale data as the hash input for this generated bundle before esbuild assigns the filename. There is still one shared filename across locales, and no output files or imports are rewritten for hashing. Application chunks, workers, user-supplied polyfills, and watch builds retain their current hashing.
Does this PR introduce a breaking change?