Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Fix stack of undefined issue - #5513

Open
LuChenZhi wants to merge 20 commits into
angular:masterfrom
LuChenZhi:master
Open

LuChenZhi wants to merge 20 commits into
angular:masterfrom
LuChenZhi:master

Conversation

@LuChenZhi

Copy link
Copy Markdown

In the default logic, this err object should be an Object or String. But in my case when the err is undefined or null, this code will throw an issue as below image. I add a logic to check if the err is not null or undefined.

image

heathkit and others added 20 commits October 14, 2019 23:45
We can't upgrade the version of Selenium without transitioning off the
control flow and breaking a bunch of people. Chrome v75 introduced the
new W3C actions API. Unfortunately, we can't update to support that
API without introducing other breakages, so v74 is the last version
of Chrome that will work with Protractor 5.

You can download a Chrome v74 snapshot from https://commondatastorage.googleapis.com/chromium-browser-snapshots/Linux_x64/638880/chrome-linux.zip

You might also need to pass "--no-sandbox" flag to Chrome
Doing this automatically means we can't pin the version of webdriver
that we use in CI. Instead, we run update in the circle config.
…oxy to 4.5.4

travis_wait is not needed if the sauce connect proxy logs are written to
stdout. This makes debugging proxy problems from the CI logs much
easier. This commit also updates the debugging command to use the
`--doctor` flag.

Other changes include:
1. Upgrade sauce-connect proxy from 4.4.1 to 4.5.4
Optimist has been deprecated over 2 years ago as has a security vulnerability. With this change we use it's successor `yargs`.

Closes: angular#5413
BREAKING CHANGE:

Node.Js version 6 and 8 are no longer supported. Please update to Node.Js 10+

Closes angular#5431