Skip to content
This repository was archived by the owner on Jan 17, 2021. It is now read-only.

Solves proxy issue, closes #74 when proxy is set at .profile - #121

Merged
deansheather merged 2 commits into
coder:masterfrom
eargollo:proxy-support
Jun 27, 2019
Merged

deansheather merged 2 commits into
coder:masterfrom
eargollo:proxy-support

Conversation

@eargollo

Copy link
Copy Markdown
Contributor

No description provided.

@eargollo eargollo mentioned this pull request Jun 18, 2019

@deansheather deansheather left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we can't merge this until you set proper git user details and sign the commit with PGP.

git config --global user.name "name"
git config --global user.email "email"

@eargollo

Copy link
Copy Markdown
Contributor Author

Weird. This is my .gitconfig:

$ cat ~/.gitconfig
[core]
        autocrlf = false
        eol = lf
[user]
        name = Eduardo Argollo
        email = eduardo@hp.com
[alias]
        aliases = config --get-regexp alias
        s = status -s
        psu = push --set-upstream
        lg=log --graph --pretty=format:'%Cred%h%Creset -%C(yellow)%d%Creset %s %Cgreen(%cr) %C(bold blue)<%an>%Creset' --abbrev-commit --date=relative

What should I do? Create another branch, push the code again and do a new PR?

Thanks.

@deansheather

Copy link
Copy Markdown