Repository navigation
Conversation
Historic enable() compiled '*' to '.*?'. disable() only inverted a trailing wildcard, so patterns like "*:error:*" came back as ".*?:error:*" and enable() rejected them. Normalize that encoding so enable(disable()) accepts mid-string wildcards and skip namespaces. Fixes debug-js#918
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
enable(disable())should restore the same namespaces, including mid-string wildcards and skip patterns.disable()historically rebuilt the namespace string from compiled regexes and only inverted a trailing.*?. A pattern such as*:error:*came back as.*?:error:*, whichenable()then rejected (Invalid regular expression: Nothing to repeat).Normalize that historic
.*?encoding back to*when enabling and when rebuilding the disable() string, so the documented temporary-disable round-trip works for wildcards and skips.Fixes #918