Skip to content

fix(notifications): mark subscription tools destructive - #2936

Merged
SamMorrowDrums merged 1 commit into
mainfrom
sammorrowdrums-explicit-protocol-annotations
Aug 19, 2026
Merged

SamMorrowDrums merged 1 commit into
mainfrom
sammorrowdrums-explicit-protocol-annotations

Conversation

@SamMorrowDrums

@SamMorrowDrums SamMorrowDrums commented Jul 23, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • explicitly mark both notification subscription management tools as destructive
  • assert the annotation in unit tests and tool snapshots
  • preserve the existing conservative client UX while making the intent independent of protocol defaults

Rationale

The MCP 2026-07-28 specification defines destructiveHint: false to mean that a tool performs only additive updates. Both tools expose a delete action that removes a subscription, and annotations apply to the whole tool rather than individual action values. They therefore need to advertise destructiveHint: true.

The protocol default remains true, so this does not change effective behavior. It makes the behavior conscious and explicit under modelcontextprotocol/go-sdk v1.7.0, which represents this default-true field as an optional pointer.

Specification: https://modelcontextprotocol.io/specification/2026-07-28/schema#toolannotations

This supersedes #2845 and #2884, which set the hint to false.

Closes #2841

Copilot AI review requested due to automatic review settings July 23, 2026 10:36
@SamMorrowDrums
SamMorrowDrums requested a review from a team as a code owner July 23, 2026 10:36