You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(notifications): mark subscription tools destructive - #2936
explicitly mark both notification subscription management tools as destructive
assert the annotation in unit tests and tool snapshots
preserve the existing conservative client UX while making the intent independent of protocol defaults
Rationale
The MCP 2026-07-28 specification defines destructiveHint: false to mean that a tool performs only additive updates. Both tools expose a delete action that removes a subscription, and annotations apply to the whole tool rather than individual action values. They therefore need to advertise destructiveHint: true.
The protocol default remains true, so this does not change effective behavior. It makes the behavior conscious and explicit under modelcontextprotocol/go-sdkv1.7.0, which represents this default-true field as an optional pointer.
Summary
Rationale
The MCP
2026-07-28specification definesdestructiveHint: falseto mean that a tool performs only additive updates. Both tools expose adeleteaction that removes a subscription, and annotations apply to the whole tool rather than individual action values. They therefore need to advertisedestructiveHint: true.The protocol default remains
true, so this does not change effective behavior. It makes the behavior conscious and explicit undermodelcontextprotocol/go-sdkv1.7.0, which represents this default-true field as an optional pointer.Specification: https://modelcontextprotocol.io/specification/2026-07-28/schema#toolannotations
This supersedes #2845 and #2884, which set the hint to
false.Closes #2841