Skip to content

fix(commit): bound co_authors trailer parsing #2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Byron merged 1 commit into from
Sep 29, 2026
Merged

fix(commit): bound co_authors trailer parsing #2257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions git/objects/commit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
from io import BytesIO
import logging
import os
import re
from subprocess import Popen, PIPE
from time import altzone, daylight, localtime, time, timezone
import warnings
Expand Down Expand Up @@ -964,12 +963,21 @@ def co_authors(self) -> List[Actor]:
co_authors = []

if self.message:
results = re.findall(
r"^Co-authored-by: (.*) <(.*?)>$",
str(self.message),
re.MULTILINE,
)
for author in results:
co_authors.append(Actor(*author))
# Scan line by line instead of matching `(.*) <(.*?)>` across the whole
# message. On a single trailer line that repeats " <" without ever closing
# a ">", greedy backtracking over each " <" made the regex run in O(n^2)
# time, so a large (fully attacker-controlled) commit message could stall