[.NET] Upgrade user project's TargetFramework to net8.0 - #100195
Merged
Merged
Conversation
raulsntos
force-pushed
the
dotnet/upgrade-tfm
branch
from
December 9, 2024 10:17
41da5b5 to
861eccb
Compare
Contributor
|
I'm not sure if it's an appropriate place to mention this, but the existing upgrade mechanism seems to removes the blank lines in csproj when updating, that is, the following csproj: Details<Project Sdk="Godot.NET.Sdk/4.3.0">
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<LangVersion>12</LangVersion>
<Nullable>enable</Nullable>
<EnableDynamicLoading>true</EnableDynamicLoading>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="GDTask" Version="1.3.0"/>
<PackageReference Include="gdUnit4.api" Version="4.3.1"/>
</ItemGroup>
</Project>will becomes this after the upgrade: Details<Project Sdk="Godot.NET.Sdk/4.4.0">
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<LangVersion>12</LangVersion>
<Nullable>enable</Nullable>
<EnableDynamicLoading>true</EnableDynamicLoading>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="GDTask" Version="1.3.0"/>
<PackageReference Include="gdUnit4.api" Version="4.3.1"/>
</ItemGroup>
</Project> |
raulsntos
force-pushed
the
dotnet/upgrade-tfm
branch
from
December 10, 2024 08:34
861eccb to
6107470
Compare
Member
Author
|
It's somewhat unrelated but an easy fix so I decided to include it. |
akien-mga
approved these changes
Dec 17, 2024
Member
|
Needs rebase. For the record the 4.4-dev7 build is planned for Thursday, do you want this PR included by then, or do you prefer to wait for it to be merged right after, and then included in beta1 in January? |
- Upgrades the TFM for new created projects to `net8.0`. - Implements system to upgrade TFM for existing projects to `net8.0`.
raulsntos
force-pushed
the
dotnet/upgrade-tfm
branch
from
December 18, 2024 01:50
6107470 to
8d41b5a
Compare
Member
Author
|
I would prefer to include it in 4.4-dev7 so it's in the same release that makes |
Member
|
Thanks! |
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
[.NET] Upgrade user project's TargetFramework to `net8.0`
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
[.NET] Upgrade user project's TargetFramework to `net8.0`
wangshucheng
pushed a commit
to wangshucheng/godot
that referenced
this pull request
Aug 27, 2026
[.NET] Upgrade user project's TargetFramework to `net8.0`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
net8.0.net8.0.