[TextEdit] Draw guidelines under the text and caret. - #108599
Merged
Merged
Conversation
Member
|
Guidelines are something specific to CodeEdit, no? The new method could have more generic name, like |
Member
Author
Yes, but I can't think of anything else that cab be drawn between background and text.
It's not on the background, so not sure what the beast name would be. |
KoBeWi
reviewed
Jul 14, 2025
KoBeWi
reviewed
Jul 14, 2025
KoBeWi
approved these changes
Jul 14, 2025
bruvzg
force-pushed
the
te_guideline_order
branch
from
July 14, 2025 13:30
e7cfe7b to
89d710b
Compare
bruvzg
force-pushed
the
te_guideline_order
branch
from
July 14, 2025 13:32
89d710b to
8624134
Compare
Contributor
|
Thanks! |
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
[TextEdit] Draw guidelines under the text and caret.
wangshucheng
pushed a commit
to wangshucheng/godot
that referenced
this pull request
Aug 27, 2026
[TextEdit] Draw guidelines under the text and caret.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #92238
Fixes #108481
Adds an internal virtual method to draw guidelines in the middle of
TextEditdraw instead of using ownDRAW.Before:
After:
