[.NET] Fix Quaternion(Vector3, Vector3) constructor when vectors are the same - #109281
Merged
Merged
Conversation
raulsntos
commented
Aug 3, 2025
Member
- As @aaronfranke rightly pointed out, in C++ Quaternions are default initialized to the identity, so we have to set the X, Y, Z, and W values before returning.
- Fixes Quaternion(Vector3 arcFrom, Vector3 arcTo) returning (0,0,0,0) in C# #109261
aaronfranke
approved these changes
Aug 4, 2025
Contributor
|
Thanks! |
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
…rnion-ctor [.NET] Fix `Quaternion(Vector3, Vector3)` constructor when vectors are the same
wangshucheng
pushed a commit
to wangshucheng/godot
that referenced
this pull request
Aug 27, 2026
…rnion-ctor [.NET] Fix `Quaternion(Vector3, Vector3)` constructor when vectors are the same
Shane-Gadsby
pushed a commit
to Shane-Gadsby/godotwebgpu
that referenced
this pull request
Sep 21, 2026
…rnion-ctor [.NET] Fix `Quaternion(Vector3, Vector3)` constructor when vectors are the same
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.