Skip to content

Fix custom tracks causing issues on reimport - #39968

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
lordkettune:custom-tracks-fix
Jul 3, 2020
Merged

Fix custom tracks causing issues on reimport#39968
akien-mga merged 1 commit into
godotengine:masterfrom
lordkettune:custom-tracks-fix

Conversation

@lordkettune

@lordkettune lordkettune commented Jun 30, 2020 •
edited by akien-mga
Loading

Copy link
Copy Markdown
Contributor

Upon importing a scene with custom tracks enabled, the importer was treating all of the tracks as custom tracks, meaning that when reimported it would overwrite the tracks with the previously imported ones. I just deleted the bit of code that did that.

Also fixed an issue with copy_track in which it would try to copy a value track's update mode even if it wasn't a value track, which led to it printing a ton of error messages each time you reimported a scene.

(This is my first time contributing here by the way, let me know if I'm doing anything wrong)

Bugsquad edit: Fixes #39959.

@aaronfranke

aaronfranke commented Jun 30, 2020

Copy link
Copy Markdown
Member

See also #39657, cc @Sl3dge78 @reduz.

@aaronfranke aaronfranke added this to the 4.0 milestone Jun 30, 2020
@lordkettune

lordkettune commented Jun 30, 2020

Copy link
Copy Markdown
Contributor Author

That PR must've been what broke it. I think they were calling anim->set_imported_track(i, false) to fix the warning on the animation editor displaying when it shouldn't be, which is also annoying, but it broke the importer as a result. It should be doing the exact opposite if anything, which it looks like it was before that PR.