Skip to content

[3.x] Backport glTF module with scene export support - #49120

Merged
akien-mga merged 2 commits into
godotengine:3.xfrom
lyuma:gltf-module-3.x
May 31, 2021
Merged

akien-mga merged 2 commits into
godotengine:3.xfrom
lyuma:gltf-module-3.x

Conversation

@lyuma

@lyuma lyuma commented May 26, 2021

Copy link
Copy Markdown
Contributor

Updated version of gltf2 module by @fire including the preliminary GLTF Export support.

Optimistically includes a backport of #48915 as I needed this bugfix to test my content. It's the last commit in the chain and can be ignored if necessary.

Note that GLTF Export crashes when given complicated skinned meshes. This crash is also present in Master. I will need some additional help from fire to resolve export-related bugs.

In this version, I collapsed the commit history.

Supersedes #46783
Supersedes #49051

@lyuma
lyuma requested a review from a team as a code owner May 26, 2021 21:22
@lyuma
lyuma force-pushed the gltf-module-3.x branch from 0930347 to 062e1ab Compare May 26, 2021 21:28
Comment thread modules/gltf/doc_classes/EditorSceneImporterGLTF.xml Outdated

@aaronfranke aaronfranke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on the TPS demo. Overall works great in my testing, with the same notes as I made here of slightly different behavior (technically it doesn't break compatibility as existing projects should keep working, but for best results user projects should be updated manually, otherwise there are duplicated imported meshes).

On the addition of the empty documentation files: Filling these in would be nice, but it's not a blocker for this PR in my opinion. It might make sense to get this merged in sooner rather than later, and the documentation can be written in another PR.

This will need approval from @fire before it can be merged.

@fire fire left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We updated the master pr for skeletons bones that are also meshes. So merging this pr is linked to that being done.

I have prs incoming for export improvements

@fire fire left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge because #49119 was merged.

Edited:

Straightforward conflicts because of the changes to the older gltf importer. (49119)

fire and others added 2 commits May 31, 2021 13:18
Fix issue when two skeletons end up directly parented.
Prevent animating TRS for skinned Mesh node.
Fix animating weights on meshes with targets but no weights.
@lyuma
lyuma force-pushed the gltf-module-3.x branch from 5fad1dc to d699600 Compare May 31, 2021 20:18
@lyuma

lyuma commented May 31, 2021

Copy link
Copy Markdown
Contributor Author

Updated the PR for godot 3.x and tested on my various gltf test scenes.

@akien-mga akien-mga changed the title Gltf module 3.x Backport glTF module with scene export support May 31, 2021
@akien-mga akien-mga changed the title Backport glTF module with scene export support [3.x] Backport glTF module with scene export support May 31, 2021
@akien-mga
akien-mga merged commit 9b35708 into godotengine:3.x May 31, 2021
@akien-mga

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants