Skip to content

Streamline the project import workflow. - #51478

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
starry-abyss:import_project_workflow
Aug 29, 2023
Merged

akien-mga merged 1 commit into
godotengine:masterfrom
starry-abyss:import_project_workflow

Conversation

@starry-abyss

@starry-abyss starry-abyss commented Aug 10, 2021

Copy link
Copy Markdown
Contributor

The goal of this PR is to ease the steps required to import a project.

Screenshot 2023-07-30 at 17 17 55

After clicking Import, the file selection dialog is immediately shown (previously one needed an extra button click).

The project file selection dialog now also supports selecting a directory, similar to Scan mode. Changes to Any mode of the selection dialog are because I wanted it to offer full functionality of both File and Directory selection modes.

Notes:

  1. I had to still show the original dialog together in the background of file selection dialog, because otherwise the content of file selection dialog isn't rendered. The drawback is that when hitting Cancel in the file selection dialog, we see the original dialog, while ideally it shouldn't be shown on the first Cancel after clicking Import.

Maybe we should change the hierarchy of the dialogs to be siblings?

  1. I was going to also merge Import and Scan, but not sure about the best approach to show Scan option in the UI of Import. Maybe it's for after this PR is merged.

  2. The lines below are because in the original PR there was no issue described in 1). If we decide to ignore 1), then I think they can be removed:

// if not already shown
show_dialog();

Relaled: godotengine/godot-proposals#2483

@starry-abyss
starry-abyss requested a review from a team as a code owner August 10, 2021 17:45
@Calinou Calinou added this to the 4.0 milestone Aug 10, 2021