SpriteFramesEditor Fix preview grid in "Select Frames" dialog - #52461

Merged

akien-mga merged 1 commit into

godotengine:masterfrom

kleonc:sprite-frames-dialog-fix-drawing

Sep 17, 2021

kleonc commented Sep 7, 2021 •

edited

Loading

Member

Fixes #52099 (I'll probably enhance this dialog in another PR, this one is bugfix only).
Fixes #52745.
Cherry-pickable 3.x, 3.3.

Makes grid being drawn according to the frames this dialog outputs (it allows integer-only frame sizes), scaling/zooming wasn't properly taken into account. Input handling is changed accordingly too. Output frames are unchanged, the preview was broken.

Example:

so the frame size is (64, 64) / (13, 11) = (4, 5)

`3.4.beta4`:	this PR (against `3.x`):


          SpriteFramesEditor Fix preview grid in "Select Frames" dialog

ad7a610

YeldhamDev added bug topic:editor cherrypick:3.3 cherrypick:3.x labels

YeldhamDev added this to the 4.0 milestone

kleonc mentioned this pull request

Select frames window shows misaligned grid at certain zoom levels #52745

Closed

akien-mga approved these changes

View reviewed changes

akien-mga merged commit 87de2e7 into godotengine:master

akien-mga commented Sep 17, 2021

Member

Thanks!

kleonc deleted the sprite-frames-dialog-fix-drawing branch

September 18, 2021 07:24

akien-mga commented Sep 21, 2021

Member