Skip to content

[macOS] Add empty translation files to the editor app bundle, to allow translation detection by the OS. - #52945

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
bruvzg:macos_editor_translation
Nov 8, 2021
Merged

[macOS] Add empty translation files to the editor app bundle, to allow translation detection by the OS.#52945
akien-mga merged 1 commit into
godotengine:masterfrom
bruvzg:macos_editor_translation

Conversation

@bruvzg

@bruvzg bruvzg commented Sep 22, 2021

Copy link
Copy Markdown
Member

Adds a bunch of empty Info.plist translation files to ensure macOS is detecting supported languages correctly.

System language settings:
Screenshot 2021-09-22 at 20 42 27

@bruvzg bruvzg added this to the 4.0 milestone Sep 22, 2021
@bruvzg
bruvzg force-pushed the macos_editor_translation branch from 75abee6 to 3b4de84 Compare September 22, 2021 20:33
@bruvzg
bruvzg marked this pull request as ready for review September 22, 2021 20:33
@bruvzg
bruvzg requested a review from a team as a code owner September 22, 2021 20:33
@bruvzg

bruvzg commented Sep 22, 2021

Copy link
Copy Markdown
Member Author

macOS detects all locales, except "pr" Pirate.

But locale auto selection does not work with some languages since editor do not check only for a full match or locale with the language code only.

Editor locales are zh_CN, zh_TW, zh_HK and sr_Cyrl.
OS locales zh_Hans_{your_countly_code}, zh_Hant_{your_countly_code}, zh_Hant_HK and sr_{your_countly_code}.

Locale selection code definitely need some improvement.

@akien-mga
akien-mga merged commit e6ffb10 into godotengine:master Nov 8, 2021
@akien-mga

akien-mga commented Nov 8, 2021

Copy link
Copy Markdown
Member

Thanks!

@bruvzg
bruvzg deleted the macos_editor_translation branch November 9, 2021 05:43
@bruvzg bruvzg mentioned this pull request Feb 3, 2022
Merged
@akien-mga akien-mga added cherrypick:3.4 cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Feb 3, 2022
@akien-mga

akien-mga commented Feb 10, 2022

Copy link
Copy Markdown
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Feb 10, 2022
@bruvzg bruvzg mentioned this pull request Feb 12, 2022
Merged
@akien-mga

akien-mga commented Feb 17, 2022

Copy link
Copy Markdown
Member

Cherry-picked for 3.4.3.

BendyLand pushed a commit to BendyLand/voltaire that referenced this pull request Aug 2, 2026
@akien-mga
Merge pull request godotengine#52945 from bruvzg/macos_editor_transla…
8a1786c 
…tion
BendyLand pushed a commit to BendyLand/voltaire that referenced this pull request Aug 2, 2026
@akien-mga
Merge pull request godotengine#52945 from bruvzg/macos_editor_transla…
12c682a 
…tion