Fix DirAccessWindows::make_dir() choking on ".." - #66467
Merged
Merged
Conversation
`CreateDirectoryW()` chokes on absolute paths that contain `..` example: "C:\\workspace\\..\\games\\assets" Simplifying the path before creating the dir fixes this.
bruvzg
approved these changes
Sep 28, 2022
bruvzg
left a comment
Member
There was a problem hiding this comment.
In case of make_dir, we are using \\?\ prefixed paths to avoid path length limitations, and automatic expansion is disabled for these, so part need to be absolute.
Member
|
Thanks! |
Member
|
Cherry-picked for 3.6. |
Member
|
Cherry-picked for 3.5.2 |
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
…dows make_dir() choking on ".."
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
…dows make_dir() choking on ".."
wangshucheng
pushed a commit
to wangshucheng/godot
that referenced
this pull request
Aug 27, 2026
…dows make_dir() choking on ".."
Shane-Gadsby
pushed a commit
to Shane-Gadsby/godotwebgpu
that referenced
this pull request
Sep 21, 2026
…dows make_dir() choking on ".."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateDirectoryW()chokes on absolute paths that contain "..". It returns an error 123: "The filename, directory name, or volume label syntax is incorrect."Example:
C:\\workspace\\..\\games\\assetsThis causes
DirAccessWindows::make_dir()to fail.Simplifying the path before creating the dir fixes this.