Fix drawing of 2D skeletons in the RD renderer. - #68863
Merged
Merged
Conversation
Also clean up skeleton code in preparation for adding them to GLES3 Properly update Mesh2D AABBs when skeleton is updated
clayjohn
force-pushed
the
RD-2D-skeleton
branch
from
November 19, 2022 07:37
8daa6e2 to
0e5a98c
Compare
akien-mga
approved these changes
Nov 19, 2022
Member
|
Thanks! |
Member
Is that backportable for 3.x? |
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
Fix drawing of 2D skeletons in the RD renderer.
BendyLand
pushed a commit
to BendyLand/voltaire
that referenced
this pull request
Aug 2, 2026
Fix drawing of 2D skeletons in the RD renderer.
wangshucheng
pushed a commit
to wangshucheng/godot
that referenced
this pull request
Aug 27, 2026
Fix drawing of 2D skeletons in the RD renderer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #59451
Fixes: #35726
There were multiple issues:
To solve the culling issue we do 2 things:
The first two problems stopped Skeletons from working at all. After I solved those I discovered the other problems and slowly added to this PR.
The rest of the code is removing dead code that hasn't been doing anything. I'm doing this in preparation for fixing up some other lingering problems with 2D skeletons and adding skeletons to GLES3. Now that Skeletons are working well in the RD renderer I can add Skeletons to the GLES3 renderer