Skip to content

Fix writing value for hand-tracking V2.0 to AndroidManifest.xml - #71231

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
tom95:fix-android-manifest-hand-tracking-v2
Jan 12, 2023
Merged

akien-mga merged 1 commit into
godotengine:masterfrom
tom95:fix-android-manifest-hand-tracking-v2

Conversation

@tom95

@tom95 tom95 commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

Due to a typo, the value for the meta-data tag for the hand-tracking-version was never set. It should be set in the "value" attribute, not in the "name" attribute.

Corresponding excerpt from the AndroidManifest.xml:

        <meta-data
            android:name="xr_hand_tracking_version_name"
            android:value="xr_hand_tracking_version_value"/>

Compatible with 3.x

@tom95
tom95 requested a review from a team as a code owner January 11, 2023 17:35
@akien-mga akien-mga added bug platform:android cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:export cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Jan 11, 2023
@akien-mga akien-mga added this to the 4.0 milestone Jan 11, 2023
@akien-mga
akien-mga merged commit 94cf65a into godotengine:master Jan 12, 2023
@akien-mga

Copy link
Copy Markdown
Member

Thanks!

@akien-mga

Copy link
Copy Markdown
Member

Cherry-picked for 3.6.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jan 20, 2023
@akien-mga

Copy link
Copy Markdown
Member

Cherry-picked for 3.5.2.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Jan 20, 2023
BendyLand pushed a commit to BendyLand/voltaire that referenced this pull request Aug 2, 2026
…hand-tracking-v2

Fix writing value for hand-tracking V2.0 to AndroidManifest.xml
BendyLand pushed a commit to BendyLand/voltaire that referenced this pull request Aug 2, 2026
…hand-tracking-v2

Fix writing value for hand-tracking V2.0 to AndroidManifest.xml
wangshucheng pushed a commit to wangshucheng/godot that referenced this pull request Aug 27, 2026
…hand-tracking-v2

Fix writing value for hand-tracking V2.0 to AndroidManifest.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants