Skip to content

C#: Fixed delegate docstring logic - #80631

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
Repiteo:C#-delegate-docstring
Aug 16, 2023
Merged

C#: Fixed delegate docstring logic#80631
akien-mga merged 1 commit into
godotengine:masterfrom
Repiteo:C#-delegate-docstring

Conversation

@Repiteo

@Repiteo Repiteo commented Aug 14, 2023

Copy link
Copy Markdown
Contributor

Extracted from #79475

  • Delegates without a relevant method no longer produce double-summaries, as the first summary is explicitly assigned to the method instead

@Repiteo
C#: Fixed delegate docstring logic
4d7c07a 
• No longer produces double-summaries
@Repiteo
Repiteo requested a review from a team as a code owner August 14, 2023 16:47
@Repiteo Repiteo mentioned this pull request Aug 14, 2023
Closed
@raulsntos raulsntos added this to the 4.2 milestone Aug 14, 2023
raulsntos
raulsntos approved these changes Aug 14, 2023
View reviewed changes

@raulsntos raulsntos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@akien-mga
akien-mga merged commit 1d852cb into godotengine:master Aug 16, 2023
@akien-mga

akien-mga commented Aug 16, 2023

Copy link
Copy Markdown
Member

Thanks!

@Repiteo
Repiteo deleted the C#-delegate-docstring branch August 16, 2023 15:00
BendyLand pushed a commit to BendyLand/voltaire that referenced this pull request Aug 2, 2026
@akien-mga
Merge pull request godotengine#80631 from Repiteo/C#-delegate-docstring
e34f3f3 
C#: Fixed delegate docstring logic
BendyLand pushed a commit to BendyLand/voltaire that referenced this pull request Aug 2, 2026
@akien-mga
Merge pull request godotengine#80631 from Repiteo/C#-delegate-docstring
4547993 
C#: Fixed delegate docstring logic
wangshucheng pushed a commit to wangshucheng/godot that referenced this pull request Aug 27, 2026
@akien-mga
Merge pull request godotengine#80631 from Repiteo/C#-delegate-docstring
4754e13 
C#: Fixed delegate docstring logic
Shane-Gadsby pushed a commit to Shane-Gadsby/godotwebgpu that referenced this pull request Sep 21, 2026
@akien-mga
Merge pull request godotengine#80631 from Repiteo/C#-delegate-docstring
8793709 
C#: Fixed delegate docstring logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raulsntos raulsntos raulsntos approved these changes

Assignees

No one assigned

Labels

enhancement topic:buildsystem topic:dotnet

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

3 participants

@Repiteo @akien-mga @raulsntos