Skip to content

[TextServer] Fix system font fallback and caret/selection behavior for composite characters. - #80650

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
bruvzg:comp_char_fix
Aug 18, 2023
Merged

akien-mga merged 1 commit into
godotengine:masterfrom
bruvzg:comp_char_fix

Conversation

@bruvzg

@bruvzg bruvzg commented Aug 15, 2023

Copy link
Copy Markdown
Member
  • Fixes system font fallback for composite characters.
  • Fixes caret/selection behavior for composite characters, composite characters (e.g, ❤️‍🔥) behave as one character, and graphemes of non-composite (e.g., ffi) characters do not.
Screen.Recording.2023-08-15.at.11.40.31.mov

Fixes #80621

@bruvzg bruvzg added this to the 4.2 milestone Aug 15, 2023
@bruvzg
bruvzg marked this pull request as ready for review August 15, 2023 11:46
@bruvzg
bruvzg requested review from a team as code owners August 15, 2023 11:46
@Koyper

Koyper commented Aug 18, 2023

Copy link
Copy Markdown
Contributor

Fantastic!

@akien-mga
akien-mga merged commit b51ee8b into godotengine:master Aug 18, 2023
@akien-mga

Copy link
Copy Markdown
Member

Thanks!

@bruvzg
bruvzg deleted the comp_char_fix branch August 19, 2023 08:23
BendyLand pushed a commit to BendyLand/voltaire that referenced this pull request Aug 2, 2026
[TextServer] Fix system font fallback and caret/selection behavior for composite characters.
BendyLand pushed a commit to BendyLand/voltaire that referenced this pull request Aug 2, 2026
[TextServer] Fix system font fallback and caret/selection behavior for composite characters.
wangshucheng pushed a commit to wangshucheng/godot that referenced this pull request Aug 27, 2026
[TextServer] Fix system font fallback and caret/selection behavior for composite characters.
Shane-Gadsby pushed a commit to Shane-Gadsby/godotwebgpu that referenced this pull request Sep 21, 2026
[TextServer] Fix system font fallback and caret/selection behavior for composite characters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Certain unicode surrogate pair emoji are not recognized

3 participants