Skip to content

Remove AnimatedSprite pointer when clearing editor - #84625

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
KoBeWi:yeet_sprite_node()
Nov 9, 2023
Merged

akien-mga merged 1 commit into
godotengine:masterfrom
KoBeWi:yeet_sprite_node()

Conversation

@KoBeWi

@KoBeWi KoBeWi commented Nov 8, 2023

Copy link
Copy Markdown
Member

When SpriteFramesEditor was unedited, the SpriteFrames were removed, but the node was not, resulting in some wrong conditions.

Fixes #84343

@KoBeWi
KoBeWi force-pushed the yeet_sprite_node() branch from 5403ea2 to 55f7d49 Compare November 8, 2023 17:09
@akien-mga
akien-mga requested a review from TokageItLab November 8, 2023 17:41
@akien-mga
akien-mga merged commit d1381bb into godotengine:master Nov 9, 2023
@akien-mga

Copy link
Copy Markdown
Member

Thanks!

@KoBeWi
KoBeWi deleted the yeet_sprite_node() branch November 9, 2023 10:54
BendyLand pushed a commit to BendyLand/voltaire that referenced this pull request Aug 2, 2026
Remove AnimatedSprite pointer when clearing editor
BendyLand pushed a commit to BendyLand/voltaire that referenced this pull request Aug 2, 2026
Remove AnimatedSprite pointer when clearing editor
wangshucheng pushed a commit to wangshucheng/godot that referenced this pull request Aug 27, 2026
Remove AnimatedSprite pointer when clearing editor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editor Crash when AnimationPlayer sets the animation property of an AnimatedSprite2D node to a different from currently selected one

2 participants