Skip to content

[Audio] Prevent crash in interactive playback - #90481

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
AThousandShips:interactive_playback
Jul 18, 2024
Merged

[Audio] Prevent crash in interactive playback#90481
akien-mga merged 1 commit into
godotengine:masterfrom
AThousandShips:interactive_playback

Conversation

@AThousandShips

@AThousandShips AThousandShips commented Apr 10, 2024

Copy link
Copy Markdown
Member

This is in two parts, first part is fixing the crash itself, second part is ensuring the class can't be created on its own, can remove if desired but I'd say it makes sense as these make no sense created independently as they are unconfigured

@AThousandShips AThousandShips added this to the 4.3 milestone Apr 10, 2024
@AThousandShips
AThousandShips requested a review from reduz April 10, 2024 10:36
AThousandShips
AThousandShips commented Apr 10, 2024
View reviewed changes
Comment thread modules/interactive_music/audio_stream_interactive.cpp Outdated
@MJacred MJacred mentioned this pull request May 7, 2024
Open
@AThousandShips
AThousandShips force-pushed the interactive_playback branch from 447e665 to 8a52837 Compare May 13, 2024 11:55
@AThousandShips AThousandShips modified the milestones: 4.3, 4.4 Jul 7, 2024
@AThousandShips

AThousandShips commented Jul 17, 2024

Copy link
Copy Markdown
Member Author

Realized that the classes are 4.3 so returning this to 4.3 and removing compat breakage as it doesn't for 4.3

@AThousandShips AThousandShips modified the milestones: 4.4, 4.3 Jul 17, 2024
@AThousandShips
AThousandShips requested a review from a team July 17, 2024 14:21
@akien-mga
akien-mga merged commit 83dd741 into godotengine:master Jul 18, 2024
@akien-mga

akien-mga commented Jul 18, 2024

Copy link
Copy Markdown
Member

Thanks!

@AThousandShips
AThousandShips deleted the interactive_playback branch July 18, 2024 08:51
@AThousandShips

AThousandShips commented Jul 18, 2024

Copy link
Copy Markdown
Member Author

Thank you!

BendyLand pushed a commit to BendyLand/voltaire that referenced this pull request Aug 2, 2026
@akien-mga
Merge pull request godotengine#90481 from AThousandShips/interactive_…
daa0715 
…playback

[Audio] Prevent crash in interactive playback
BendyLand pushed a commit to BendyLand/voltaire that referenced this pull request Aug 2, 2026
@akien-mga
Merge pull request godotengine#90481 from AThousandShips/interactive_…