Skip to content

fix: basic auth invalid base64 string - #2191

Merged
aldas merged 2 commits into
labstack:masterfrom
wellingguzman:fix-basic-auth-invalid-base64-string
May 27, 2022
Merged

aldas merged 2 commits into
labstack:masterfrom
wellingguzman:fix-basic-auth-invalid-base64-string

Conversation

@wellingguzman

Copy link
Copy Markdown
Contributor

fixes #2170

@codecov

codecov Bot commented May 26, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2191 (9bd1c7a) into master (d5f8837) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2191      +/-   ##
==========================================
+ Coverage   92.20%   92.26%   +0.06%     
==========================================
  Files          37       37              
  Lines        3090     3090              
==========================================
+ Hits         2849     2851       +2     
+ Misses        151      150       -1     
+ Partials       90       89       -1     
Impacted Files Coverage Δ
middleware/basic_auth.go 71.87% <100.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5f8837...9bd1c7a. Read the comment docs.

@aldas aldas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BasicAuth middleware returns 500 InternalServerError on invalid base64 strings

3 participants