Close #134566: Added settings for terminal tab default color/icon

[Aman Khalid (amanasifkhalid)]

This PR fixes #134566 by adding the settings terminal.integrated.tabs.defaultColor and terminal.integrated.tabs.defaultIcon. These settings support the same values as the "Change Terminal Color" and "Change Terminal Icon" actions. Below is a demo of this new workflow:

terminal-profile-demo.mp4

[Daniel Imms (Tyriar)]

Thanks for the PR Aman Khalid (@amanasifkhalid). This needed a little extra work, essentially replacing all instances of Codicon.terminal inside the terminal component as there's a bit of complexity to the "resolving" of the icons. I think I caught all the cases.

[Daniel Imms (Tyriar)]

Megan Rogge (@meganrogge) a full review would be helpful here as the change turned out to be fairly large

[Megan Rogge (meganrogge)]

works well 👍🏼 . I wonder if we should add a tag or include icon in the setting title for the icon's color to make it more discoverable?

[Megan Rogge (meganrogge)]

Reset to default resets it to the default that's configured - I wonder if that's what a user would expect - I'd sort of expect the color to go back to grey

reset.to.default.mov

[Megan Rogge (meganrogge)]

works well 👍🏼 . I wonder if we should add a tag or include icon in the setting title for the icon's color to make it more discoverable?

Going with terminal.integrated.tabs.defaultIconId and terminal.integrated.tabs.defaultIconColor yields this and IMO is more accurate

[Daniel Imms (Tyriar)]

Reset to default resets it to the default that's configured - I wonder if that's what a user would expect - I'd sort of expect the color to go back to grey

I had it doing this at some point and it didn't feel right. We can wait for feedback?

Going with terminal.integrated.tabs.defaultIconId and terminal.integrated.tabs.defaultIconColor yields this and IMO is more accurate

I was trying to align the wording with profiles:

vscode/src/vs/platform/terminal/common/terminalPlatformConfiguration.ts

Lines 27 to 47 in ce8b7a9

	icon: {
	description: localize('terminalProfile.icon', 'A codicon ID to associate with this terminal.'),
	type: 'string',
	enum: Array.from(Codicon.getAll(), icon => icon.id),
	markdownEnumDescriptions: Array.from(Codicon.getAll(), icon => `$(${icon.id})`),
	},
	color: {
	description: localize('terminalProfile.color', 'A theme color ID to associate with this terminal.'),
	type: ['string', 'null'],
	enum: [
	'terminal.ansiBlack',
	'terminal.ansiRed',
	'terminal.ansiGreen',
	'terminal.ansiYellow',
	'terminal.ansiBlue',
	'terminal.ansiMagenta',
	'terminal.ansiCyan',
	'terminal.ansiWhite'
	],
	default: null
	},

I created a follow up in #154354 to add it to the setting description and align better since the profiles setting just uses icon and color.

[Megan Rogge (meganrogge)]

Just realized that this doesn't work in the case of the multi-root repository because the setting is per workspace ATM, so you can't distinguish between the terminals that way.

Folder settings are undefined when in a multi-root repo

[Daniel Imms (Tyriar)]

Folder settings are undefined when in a multi-root repo

Isn't it the other way; folder settings are only set when in a multi-root repo?

[Megan Rogge (meganrogge)]

Daniel Imms (@Tyriar) I'm
Hoping I was just doing something wrong. See if you're able to configure this when in a multi repo workspace - I couldn't

[Daniel Imms (Tyriar)]

Megan Rogge (@meganrogge) fixing for august: #156806