Repository navigation
Add Makefile tests for upgraded grammar: comma, comment, shebang - #154625
Merged
Merged
Conversation
1. Add comma separator for function calls and conditions. 2. Escaping a comment with an odd count of backslashes (\#, \\\#). 3. Match debian/rules files based on shebang.
Contributor
Author
|
So, yes, tests should fail until the Makefile grammar is updated from the upstream. |
Alex Ross (alexr00)
approved these changes
Jul 12, 2022
Alex Ross (alexr00)
left a comment
Member
There was a problem hiding this comment.
Alexander Fadeev (@fadeevab) thank you for the new tests!
Johannes Rieken (jrieken)
approved these changes
Jul 12, 2022
Andrea Mah (andreamah)
pushed a commit
that referenced
this pull request
Jul 14, 2022
…4625) Add Makefile tests for upgraded grammar: comma, comment, shebang. 1. Add comma separator for function calls and conditions. 2. Escaping a comment with an odd count of backslashes (\#, \\\#). 3. Match debian/rules files based on shebang. Co-authored-by: Alex Ross <alros@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains tests for recently fixed issues in Makefile grammar:
Upgraded Makefile grammar in the upstream additionally contains an improvement:
Alex Ross (@alexr00) Hi! Long time no see! Please, pull the upgraded Makefile grammar from the upstream, and AFTER that merge this PR into the main branch, it contains new relevant tests.