Skip to content

Try to prevent update of user-type Windows installation when running as admin (#148428) - #155631

Merged
João Moreno (joaomoreno) merged 3 commits into
microsoft:mainfrom
gjsjohnmurray:fix-148428
Jul 22, 2022
Merged

João Moreno (joaomoreno) merged 3 commits into
microsoft:mainfrom
gjsjohnmurray:fix-148428

Conversation

@gjsjohnmurray

Copy link
Copy Markdown
Contributor

This PR fixes #148428

@gjsjohnmurray

Copy link
Copy Markdown
Contributor Author

/assign João Moreno (@joaomoreno)

I haven't worked out how I can test this when building OSS. Any ideas?

@joaomoreno
João Moreno (joaomoreno) marked this pull request as ready for review July 21, 2022 13:52
@joaomoreno

João Moreno (joaomoreno) commented Jul 21, 2022 •

Copy link
Copy Markdown
Contributor

Thanks for the PR John Murray (@gjsjohnmurray)! I've changed it slightly so we run the check a bit earlier. I'll just run an internal build and test this out.

https://dev.azure.com/monacotools/Monaco/_build/results?buildId=178941&view=results

@joaomoreno João Moreno (joaomoreno) added this to the July 2022 milestone Jul 21, 2022
@joaomoreno
João Moreno (joaomoreno) merged commit 8b7a0d8 into microsoft:main Jul 22, 2022
@gjsjohnmurray
John Murray (gjsjohnmurray) deleted the fix-148428 branch July 22, 2022 14:45
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows: Prevent update service from activating if running as Admin in User install

3 participants