Repository navigation
Conversation
|
Review requested:
|
|
@nodejs/loaders @mcollina @ShogunPanda |
|
I don't think you need to modify on the C++. |
|
in current form this should fix all the regressions that I was made aware of. |
|
Have you tried the following case: hooks.mjs t1.js t2.js t3.js Note that there is no |
@ShogunPanda I tried that now. Works IMO exactly like v22.1 worked (and like 22.2.0 for that matter). What is the expectation? |
|
Well, that the hooks are executed. Which is not the case even on 22.1. I think this should be fixed as well as part of this. |
the reason for that is unrelated to the single hooks thread. If that should work I am for creating a separate issue and deal with that on its own. What do you think? |
this is a fix for #53182
by implementing a guard on the native side, we can ensure that the internal customization hooks thread is instantiated only once but not necessarily from the main thread.
https://github.com/ShogunPanda/hooks-repro example is not hanginng
the second commit reenables the tests that were skipped because
module.register()was temporarily not supported on worker threads.One is still failing on workers. Currently analyzing.
This implements the fix based on solution number 2. from this comment
alternative to #53183