Repository navigation
test: add missing r.close() calls in REPL multiline tests - #60226
Merged
nodejs-github-bot merged 1 commit intoNov 17, 2025
Merged
Conversation
Adds missing REPL instance cleanup calls to prevent resource leaks in test/parallel/test-repl-multiline-navigation.js. Each test now properly closes the REPL instance after testing cursor navigation.
Han5991
marked this pull request as ready for review
October 12, 2025 08:07
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60226 +/- ##
=======================================
Coverage 88.56% 88.57%
=======================================
Files 704 704
Lines 208125 208125
Branches 40003 40009 +6
=======================================
+ Hits 184332 184338 +6
- Misses 15809 15815 +6
+ Partials 7984 7972 -12 🚀 New features to boost your workflow:
|
BridgeAR
approved these changes
Nov 4, 2025
Collaborator
Contributor
Author
|
The CI run shows failures on Linux and AIX platforms. Could you please trigger a new CI run to check if these are flaky test failures? The changes in this PR only add missing Thank you! |
Collaborator
Collaborator
|
Landed in 8131d38 |
targos
pushed a commit
that referenced
this pull request
Nov 27, 2025
Adds missing REPL instance cleanup calls to prevent resource leaks in test/parallel/test-repl-multiline-navigation.js. Each test now properly closes the REPL instance after testing cursor navigation. PR-URL: #60226 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
aduh95
pushed a commit
that referenced
this pull request
Jan 9, 2026
Adds missing REPL instance cleanup calls to prevent resource leaks in test/parallel/test-repl-multiline-navigation.js. Each test now properly closes the REPL instance after testing cursor navigation. PR-URL: #60226 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 13, 2026
Adds missing REPL instance cleanup calls to prevent resource leaks in test/parallel/test-repl-multiline-navigation.js. Each test now properly closes the REPL instance after testing cursor navigation. PR-URL: #60226 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
aduh95
pushed a commit
that referenced
this pull request
Jan 19, 2026
Adds missing REPL instance cleanup calls to prevent resource leaks in test/parallel/test-repl-multiline-navigation.js. Each test now properly closes the REPL instance after testing cursor navigation. PR-URL: #60226 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Summary
r.close()calls to 4 test cases intest/parallel/test-repl-multiline-navigation.jsTest plan
./node test/parallel/test-repl-multiline-navigation.jstools/test.py repl