Skip to content

test: add missing r.close() calls in REPL multiline tests - #60226

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Han5991:fix/repl-multiline-test-cleanup
Nov 17, 2025
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Han5991:fix/repl-multiline-test-cleanup

Conversation

@Han5991

@Han5991 Han5991 commented Oct 12, 2025 •

Copy link
Copy Markdown
Contributor

Summary

  • Adds missing r.close() calls to 4 test cases in test/parallel/test-repl-multiline-navigation.js
  • Prevents resource leaks by properly cleaning up REPL instances after each test
  • Ensures test isolation and improves reliability in CI environments
image image

Test plan

  • Run the modified test file: ./node test/parallel/test-repl-multiline-navigation.js
  • Verify all tests pass without resource warnings
  • Run full REPL test suite: tools/test.py repl
  • Check for any memory leak indicators in test output

Adds missing REPL instance cleanup calls to prevent resource leaks
in test/parallel/test-repl-multiline-navigation.js. Each test now
properly closes the REPL instance after testing cursor navigation.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 12, 2025
@Han5991
Han5991 marked this pull request as ready for review October 12, 2025 08:07
@codecov

codecov Bot commented Oct 12, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.57%. Comparing base (f9fcc74) to head (57da92f).
⚠️ Report is 291 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #60226   +/-   ##
=======================================
  Coverage   88.56%   88.57%           
=======================================
  Files         704      704           
  Lines      208125   208125           
  Branches    40003    40009    +6     
=======================================
+ Hits       184332   184338    +6     
- Misses      15809    15815    +6     
+ Partials     7984     7972   -12     

see 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BridgeAR BridgeAR added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Nov 4, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 4, 2025
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@Han5991

Han5991 commented Nov 5, 2025

Copy link
Copy Markdown
Contributor Author

@BridgeAR

The CI run shows failures on Linux and AIX platforms. Could you please trigger a new CI run to check if these are flaky test failures?

The changes in this PR only add missing r.close() calls in REPL multiline tests, which shouldn't affect platform-specific behavior.

Thank you!

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70063/

@Renegade334 Renegade334 added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 17, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 17, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 8131d38 into nodejs:main Nov 17, 2025
32 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 8131d38

targos pushed a commit that referenced this pull request Nov 27, 2025
Adds missing REPL instance cleanup calls to prevent resource leaks
in test/parallel/test-repl-multiline-navigation.js. Each test now
properly closes the REPL instance after testing cursor navigation.

PR-URL: #60226
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
aduh95 pushed a commit that referenced this pull request Jan 9, 2026
Adds missing REPL instance cleanup calls to prevent resource leaks
in test/parallel/test-repl-multiline-navigation.js. Each test now
properly closes the REPL instance after testing cursor navigation.

PR-URL: #60226
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
RafaelGSS pushed a commit that referenced this pull request Jan 13, 2026
Adds missing REPL instance cleanup calls to prevent resource leaks
in test/parallel/test-repl-multiline-navigation.js. Each test now
properly closes the REPL instance after testing cursor navigation.

PR-URL: #60226
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
aduh95 pushed a commit that referenced this pull request Jan 19, 2026
Adds missing REPL instance cleanup calls to prevent resource leaks
in test/parallel/test-repl-multiline-navigation.js. Each test now
properly closes the REPL instance after testing cursor navigation.

PR-URL: #60226
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jan 22, 2026