Skip to content

fs: remove duplicate getValidatedPath calls - #61359

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mertcanaltin:mert/fs-remove-duplicate-getValidatedPath
Jan 20, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mertcanaltin:mert/fs-remove-duplicate-getValidatedPath

Conversation

@mertcanaltin

Copy link
Copy Markdown
Member

already validated earlier in the function
https://github.com/nodejs/node/blob/main/lib/fs.js#L1635

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Jan 12, 2026

@gurgunday gurgunday left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

nice catch!

@codecov

codecov Bot commented Jan 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.52%. Comparing base (1bd7f62) to head (4a24cda).
⚠️ Report is 81 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #61359   +/-   ##
=======================================
  Coverage   88.51%   88.52%           
=======================================
  Files         704      704           
  Lines      208739   208739           
  Branches    40274    40279    +5     
=======================================
+ Hits       184770   184778    +8     
- Misses      15968    15974    +6     
+ Partials     8001     7987   -14     
Files with missing lines Coverage Δ
lib/fs.js 98.18% <100.00%> (ø)

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lpinca