Repository navigation
quic: copy options buffer instead of detaching - #61403
Merged
Merged
Conversation
Renegade334
reviewed
Jan 16, 2026
Renegade334
left a comment
Member
There was a problem hiding this comment.
Was going to suggest a similar approach.
The commit message should probably reflect that this applies to all buffer-based quic options, not just SessionOptions#certs.
legendecas
force-pushed
the
quic-certs
branch
2 times, most recently
from
January 16, 2026 21:27
da77e1e to
b8f90b8
Compare
The certs could be allocated in a pooled buffer, like `Buffer.from`, and `Buffer.allocUnsafe` (used by `fs.readFileSync`, etc).
legendecas
force-pushed
the
quic-certs
branch
from
January 16, 2026 22:00
b8f90b8 to
7a9130c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61403 +/- ##
==========================================
- Coverage 88.53% 88.51% -0.02%
==========================================
Files 704 704
Lines 208797 208806 +9
Branches 40316 40308 -8
==========================================
- Hits 184857 184834 -23
- Misses 15923 15971 +48
+ Partials 8017 8001 -16
🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Jan 17, 2026
Collaborator
Collaborator
Collaborator
addaleax
approved these changes
Jan 21, 2026
| auto length = view->ByteLength(); | ||
| auto offset = view->ByteOffset(); | ||
| auto dest = ArrayBuffer::NewBackingStore( | ||
| isolate, length, v8::BackingStoreInitializationMode::kUninitialized); |
Member
There was a problem hiding this comment.
Would be nice if we could handle allocation failures in these calls too
The
certscould be allocated in a pooled buffer, likeBuffer.from, andBuffer.allocUnsafe(used byfs.readFileSync, etc).Refs: #61372