Skip to content

inspector: auto collect webstorage data - #62145

Merged
nodejs-github-bot merged 9 commits into
nodejs:mainfrom
islandryu:autoCollectWebStorage
Apr 6, 2026
Merged

nodejs-github-bot merged 9 commits into
nodejs:mainfrom
islandryu:autoCollectWebStorage

Conversation

@islandryu

@islandryu islandryu commented Mar 7, 2026 •

Copy link
Copy Markdown
Member

Web Storage data collection, which previously required explicitly firing events to send data to DevTools, is now performed automatically within Node.js.
Web Storage will appear in DevTools simply by specifying --experimental-storage-inspection, without requiring any code changes.

This feature relies on the changes introduced in the following change request, so it can be verified with the latest DevTools commit:
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7274801

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/inspector

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Mar 7, 2026
@codecov

codecov Bot commented Mar 7, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.71728% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.69%. Comparing base (a6e9e32) to head (57f5b49).
⚠️ Report is 244 commits behind head on main.

Files with missing lines Patch % Lines
src/inspector/dom_storage_agent.cc 82.05% 1 Missing and 6 partials ⚠️
src/node_webstorage.cc 77.27% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62145      +/-   ##
==========================================
+ Coverage   89.64%   89.69%   +0.04%     
==========================================
  Files         676      677       +1     
  Lines      206240   206871     +631     
  Branches    39514    39618     +104     
==========================================
+ Hits       184891   185544     +653     
+ Misses      13465    13451      -14     
+ Partials     7884     7876       -8     
Files with missing lines Coverage Δ
lib/internal/inspector/webstorage.js 100.00% <100.00%> (ø)
lib/internal/webstorage.js 100.00% <100.00%> (ø)
src/node_builtins.cc 75.95% <ø> (ø)
src/node_webstorage.h 83.33% <ø> (ø)
src/node_webstorage.cc 74.81% <77.27%> (+0.07%) ⬆️
src/inspector/dom_storage_agent.cc 67.74% <82.05%> (+18.06%) ⬆️

... and 102 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.