Skip to content

test: wait for ok before initial break after restart - #62807

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
inoway46:fix-flaky-wait-after-restart
May 21, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
inoway46:fix-flaky-wait-after-restart

Conversation

@inoway46

@inoway46 inoway46 commented Apr 18, 2026 •

Copy link
Copy Markdown
Contributor

Follow-up to: #62471

Waiting for Debugger attached. before waitForInitialBreak() reduced one race, but it still was not a strong enough sync point. During reconnect, debug> can be re-displayed before the CLI finishes run()/restart(), and the output can still look like:

Debugger attached.
debug>
ok
debug>

This change waits for ok before waitForInitialBreak(), so the test only starts waiting for the initial break after the CLI has completed reconnecting.

CI logs

Testing

UNUSUAL="$HOME/dir with \$unusual\"chars?'åß∂ƒ©∆¬…\`"
mkdir -p "$UNUSUAL"
ln -sfn "$PWD" "$UNUSUAL/node"
cd "$UNUSUAL/node"
  • ./tools/test.py -p actions -j1 --repeat 50 parallel/test-debugger-run-after-quit-restart

Refs: #61762

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Apr 18, 2026
@inoway46
inoway46 marked this pull request as ready for review April 19, 2026 04:02
@inoway46
inoway46 force-pushed the fix-flaky-wait-after-restart branch from 28b3e0e to 3a7bcb0 Compare April 19, 2026 04:11
@codecov

codecov Bot commented Apr 19, 2026 •