Skip to content

crypto: reject duplicate ML-KEM JWK key_ops - #62905

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:check-kem-key_ops
Apr 25, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:check-kem-key_ops

Conversation

@panva

@panva panva commented Apr 23, 2026

Copy link
Copy Markdown
Member

I missed this in #62706. Web Cryptography JWK import must reject duplicate entries in the JWK's key_ops.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva panva added confirmed-bug Issues and PRs for confirmed bugs. crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. webcrypto Issues and PRs related to the Web Crypto API. labels Apr 23, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 23, 2026
@panva
panva requested a review from ChALkeR April 23, 2026 07:18
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 23, 2026
@codecov

codecov Bot commented Apr 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.62%. Comparing base (acb1bd7) to head (ca2bb43).
⚠️ Report is 51 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62905      +/-   ##
==========================================
- Coverage   91.43%   89.62%   -1.82%     
==========================================
  Files         356      706     +350     
  Lines      150580   219201   +68621     
  Branches    23602    41989   +18387     
==========================================
+ Hits       137686   196449   +58763     
- Misses      12625    14629    +2004     
- Partials      269     8123    +7854     
Files with missing lines Coverage Δ
lib/internal/crypto/util.js 95.53% <100.00%> (+2.85%) ⬆️

... and 472 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

anonrig