Skip to content

src,sqlite: remove dead code - #63204

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
geeksilva97:remove-sqlite-dead-code
May 12, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
geeksilva97:remove-sqlite-dead-code

Conversation

@geeksilva97

Copy link
Copy Markdown
Contributor

This code was noop since condition is incorrect. Also, it's not needed for entryPoint since it's not a path

Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels May 8, 2026
@codecov

codecov Bot commented May 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.04%. Comparing base (2b6ce13) to head (d29ceae).
⚠️ Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63204      +/-   ##
==========================================
- Coverage   90.06%   90.04%   -0.03%     
==========================================
  Files         713      713              
  Lines      224942   224939       -3     
  Branches    42534    42531       -3     
==========================================
- Hits       202590   202538      -52     
- Misses      14147    14192      +45     
- Partials     8205     8209       +4     
Files with missing lines Coverage Δ
src/node_sqlite.cc 80.63% <ø> (+0.08%) ⬆️

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Renegade334 Renegade334 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels May 8, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 8, 2026