Repository navigation
deps: cherry-pick libuv/libuv@a43e543 - #63222
Merged
nodejs-github-bot merged 1 commit intoMay 12, 2026
Merged
Conversation
Original commit message:
unix: fix pedantic compiler warnings (nodejs#5052)
Fixes: libuv/libuv#5051
Fixes: nodejs#63196
Refs: libuv/libuv#5052
Refs: libuv/libuv@a43e543
Collaborator
|
Review requested:
|
jasnell
approved these changes
May 10, 2026
Collaborator
lpinca
approved these changes
May 10, 2026
juanarbol
approved these changes
May 11, 2026
Collaborator
Contributor
Author
|
@lpinca @jasnell @juanarbol does it need to be rebased since Antoine raised the PR #63209 which fixes flakes on Windows |
Member
|
@thisalihassan it should not be needed. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Renegade334
approved these changes
May 11, 2026
Cherry-picks the upstream libuv fix for two pedantic-clang warnings.
Without this
deps/uv/src/uv-common.c:960fails to compile under stricter clang configurations (bundled Chromium clang under-Werror) becauseuv__free(cpu_infos[i].model)discards theconstqualifier onuv_cpu_info_t::model.Fixes: #63196
Refs: libuv/libuv#5052