Skip to content

deps: cherry-pick libuv/libuv@a43e543 - #63222

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
thisalihassan:deps-libuv-cherry-pick-a43e543
May 12, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
thisalihassan:deps-libuv-cherry-pick-a43e543

Conversation

@thisalihassan

Copy link
Copy Markdown
Contributor

Cherry-picks the upstream libuv fix for two pedantic-clang warnings.

Without this deps/uv/src/uv-common.c:960 fails to compile under stricter clang configurations (bundled Chromium clang under -Werror) because uv__free(cpu_infos[i].model) discards the const qualifier on uv_cpu_info_t::model.

Fixes: #63196
Refs: libuv/libuv#5052

Original commit message:

    unix: fix pedantic compiler warnings (nodejs#5052)

    Fixes: libuv/libuv#5051

Fixes: nodejs#63196
Refs: libuv/libuv#5052
Refs: libuv/libuv@a43e543
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. labels May 10, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@Renegade334 Renegade334 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 10, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@thisalihassan

thisalihassan commented May 11, 2026 •

Copy link
Copy Markdown
Contributor Author

@lpinca @jasnell @juanarbol does it need to be rebased since Antoine raised the PR #63209 which fixes flakes on Windows

@lpinca

lpinca commented May 11, 2026

Copy link
Copy Markdown
Member

@thisalihassan it should not be needed.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73365/

@Renegade334 Renegade334 added the commit-queue PRs queued for automated landing through the Commit Queue. label May 11, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 12, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 349d226 into nodejs:main May 12, 2026
69 checks passed
@nodejs-github-bot