Skip to content

watch: cancel pending restart on shutdown - #63383

Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
trivikr:watch-hang-completed-child-terminate
Jun 4, 2026
Merged

nodejs-github-bot merged 4 commits into
nodejs:mainfrom
trivikr:watch-hang-completed-child-terminate

Conversation

@trivikr

@trivikr trivikr commented May 17, 2026 •

Copy link
Copy Markdown
Member

Fixes a watch mode shutdown race where a pending debounced file change could still emit after FilesWatcher.clear() closed the active watchers. That allowed watch mode to restart the child process after shutdown had already started, which could leave out/Release/node --watch --inspect processes behind and fail CI’s leftover-process check.

This cancels the pending debounce timer during watcher cleanup and makes watched child exit handling stable across overlapping restart/shutdown paths.

Noticed while examining flaky tests in ubuntu2404_sharedlibs_shared_x64/56356

13:35:08 All tests passed.
13:35:08 ps awwx | grep Release/node | grep -v grep | cat
13:35:08 2405720 ?        Sl     0:00 /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/node --inspect=0 --watch /home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/watch-mode/inspect.js
13:35:08 2405726 ?        Sl     0:00 /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/node --inspect=0 /home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/watch-mode/inspect.js
13:35:08 make[1]: *** [Makefile:648: test-ci] Error 1
13:35:08 make: *** [Makefile:674: run-ci] Error 2
13:35:08 Build step 'Conditional steps (multiple)' marked build as failure

Testing

The updated unit tests were run before/after

Before

$ python3 tools/test.py -J --mode=release \
  parallel/test-watch-mode-files_watcher-clear \
  sequential/test-watch-mode-inspect \
  parallel/test-watch-mode-files_watcher
=== release test-watch-mode-files_watcher-clear ===
Path: parallel/test-watch-mode-files_watcher-clear
node:assert:173
  throw err;
  ^

AssertionError [ERR_ASSERTION]: function should not have been called at file:///Users/trivikram/workspace/node/test/parallel/test-watch-mode-files_watcher-clear.mjs:45
called with arguments: { owners: SafeSet(0) {}, eventType: 'change' }
    at FilesWatcher.mustNotCall (/Users/trivikram/workspace/node/test/common/index.js:567:12)
    at FilesWatcher.emit (node:events:509:20)
    at Timeout._onTimeout (node:internal/watch_mode/files_watcher:104:12)
    at listOnTimeout (node:internal/timers:605:17)
    at process.processTimers (node:internal/timers:541:7) {