You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test: avoid repeated writes in watch helper - #63386
The shared watch helper was repeatedly writing the watched file in the run({ watch: true }) update path until the second run completed. On slow CI,
that can trigger another watch restart while the previous rerun is still
active. The test runner then terminates the in-flight child process with SIGTERM, and the captured output can include both a failed file-level subtest
and the next successful run.
This changes the update path to use performFileOperation(), matching the
helper’s rename/create paths. For the run() API path, that schedules a single
delayed write instead of rewriting until the second run completes. The helper
still waits for the next completed run before asserting output.
This also tightens run completion detection to count only root summary duration_ms lines, instead of any duration_ms field in the TAP output.
The shared watch helper was repeatedly writing the watched file in the
run({ watch: true })update path until the second run completed. On slow CI,that can trigger another watch restart while the previous rerun is still
active. The test runner then terminates the in-flight child process with
SIGTERM, and the captured output can include both a failed file-level subtestand the next successful run.
This changes the update path to use
performFileOperation(), matching thehelper’s rename/create paths. For the
run()API path, that schedules a singledelayed write instead of rewriting until the second run completes. The helper
still waits for the next completed run before asserting output.
This also tightens run completion detection to count only root summary
duration_mslines, instead of anyduration_msfield in the TAP output.Historical context: