Skip to content

test: disable Maglev in near-heap-limit worker test - #63398

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
trivikr:flaky-test-worker-nearheaplimit-deadlock
May 20, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
trivikr:flaky-test-worker-nearheaplimit-deadlock

Conversation

@trivikr

@trivikr trivikr commented May 18, 2026

Copy link
Copy Markdown
Member

This fixes a flaky failure in test-worker-nearheaplimit-deadlock where the
worker's intentionally tiny heap can be exhausted by Maglev compilation before
the test reaches the worker startup path it is meant to cover.

The test already disables snapshots because snapshot deserialization can hit
OOM too early. This applies the same idea to Maglev: disable it so the induced
OOM occurs during message port creation and is reported as
ERR_WORKER_OUT_OF_MEMORY.

Refs:


Assisted-by: openai:gpt-5.5

The test expects the worker to run out of memory during startup while
creating the message port. With Maglev enabled, the tiny worker heap
can be exhausted earlier while generating deoptimization data, which
changes the failure mode.

Disable Maglev so the induced OOM reaches the path covered by the test.

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: openai:gpt-5.5
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels May 18, 2026
@codecov

codecov Bot commented May 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.06%. Comparing base (1f371fc) to head (e369913).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63398      +/-   ##
==========================================
+ Coverage   90.05%   90.06%   +0.01%     
==========================================
  Files         714      714              
  Lines      225704   225704              
  Branches    42714    42726      +12     
==========================================
+ Hits       203250   203291      +41     
+ Misses      14225    14189      -36     
+ Partials     8229     8224       -5     

see 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.