Skip to content

test: remove test-node-output-v8-warning - #63469

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:remove-v8-warning
May 25, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:remove-v8-warning

Conversation

@joyeecheung

@joyeecheung joyeecheung commented May 21, 2026 •

Copy link
Copy Markdown
Member

asm.js validation is deprecated and disabled by default in V8, so there's no longer a stable user-reachable trigger for v8::Isolate::kMessageWarning. Remove the test.

Refs: https://issues.chromium.org/issues/510487707
Refs: #24365
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7832184
Fixes: nodejs/node-v8#310

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels May 21, 2026
targos
targos previously approved these changes May 21, 2026
aduh95
aduh95 previously approved these changes May 21, 2026
@aduh95

aduh95 commented May 21, 2026

Copy link
Copy Markdown
Contributor
Failed tests:
out/Release/node --expose-internals /Users/runner/work/node/node/node/test/parallel/test-v8-serdes.js
out/Release/node /Users/runner/work/node/node/node/test/parallel/test-worker-stack-overflow-stack-size.js
out/Release/node --experimental-wasm-modules /Users/runner/work/node/node/node/test/wpt/test-wasm-jsapi.mjs