Skip to content

deps: V8: backport c4d06ba586f33b8e5 - #63731

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
Javonne-liu:fix-loong64-v8-opcode-209
Jul 24, 2026
Merged

nodejs-github-bot merged 2 commits into
nodejs:mainfrom
Javonne-liu:fix-loong64-v8-opcode-209

Conversation

@Javonne-liu

@Javonne-liu Javonne-liu commented Jun 3, 2026 •

Copy link
Copy Markdown
Contributor

Fixes: #63721

LoongArch64 CI is in a failed state (https://ci.nodejs.org/job/node-test-commit-loongarch64/nodes=clfs23-64/1031/)

Always reproduces on LoongArch64 when executing the make out/doc/api/addons.html command.

Error Log:

[loongarch@90 node]$ make out/doc/api/addons.html
npm warn cli npm v11.16.0 does not support Node.js v27.0.0-pre. This version of npm supports the following node versions: `^20.17.0 || >=22.9.0`. You can find the latest version at https://nodejs.org/.

added 369 packages, and audited 371 packages in 10s

142 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
mkdir -p out/doc/api
cp -r doc/api out/doc
AssembleArchSelect Unimplemented arch_opcode is : 209
UNIMPLEMENTED code_generator_loong64: AssembleArchSelect at line 4732


#
# Fatal error in , line 0
# unimplemented code
#
#
#
#FailureMessage Object: 0x7fffee5105c0
----- Native stack trace -----

 1: 0x5555571b1748  [/home/loongarch/liujh/node/node]
 2: 0x5555596649f0 V8_Fatal(char const*, ...) [/home/loongarch/liujh/node/node]
 3: 0x555559d00344  [/home/loongarch/liujh/node/node]
 4: 0x55555a075db0  [/home/loongarch/liujh/node/node]
 5: 0x55555a0776bc  [/home/loongarch/liujh/node/node]
 6: 0x555559813558  [/home/loongarch/liujh/node/node]
 7: 0x55555981efd8  [/home/loongarch/liujh/node/node]
 8: 0x55555979c5c4  [/home/loongarch/liujh/node/node]
 9: 0x55555803e38c  [/home/loongarch/liujh/node/node]
10: 0x55555804feb4  [/home/loongarch/liujh/node/node]
11: 0x555558051b00  [/home/loongarch/liujh/node/node]
12: 0x5555588ac85c  [/home/loongarch/liujh/node/node]
13: 0x5555571b2774  [/home/loongarch/liujh/node/node]
14: 0x7fffeff7a454  [/usr/lib64/libc.so.6]
15: 0x7fffeffff8cc  [/usr/lib64/libc.so.6]
make: *** [Makefile:886: out/doc/api/addons.html] Error 133

This has been fixed in the latest commit for the v8 loong64 architecture.
(Ref: https://chromium-review.googlesource.com/c/v8/v8/+/7801520).
review.googlesource.com/c/v8/v8/+/7801520)。
I verified this locally by patching deps/v8. With the patch applied, make out/doc/api/addons.html runs successfully and the crash is completely resolved.

Origin commit message:

    [loong64][compiler] Extend Word64Select instruction functionality
    
    Change-Id: Iba762777642d2d2d3aa904f9afc1e9005139992e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7801520
    Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
    Commit-Queue: Liu Yu <liuyu@loongson.cn>
    Reviewed-by: Darius Mercadier <dmercadier@chromium.org>
    Auto-Submit: Liu Yu <liuyu@loongson.cn>
    Cr-Commit-Position: refs/heads/main@{#107619}

Refs: v8/v8@c4d06ba

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Jun 3, 2026
@Javonne-liu
Javonne-liu force-pushed the fix-loong64-v8-opcode-209 branch 3 times, most recently from 3db807e to d51bfac Compare June 3, 2026 09:21
@Renegade334

Copy link
Copy Markdown
Member

@Javonne-liu
Javonne-liu force-pushed the fix-loong64-v8-opcode-209 branch 2 times, most recently from dcf6977 to 136cba3 Compare June 10, 2026 10:01
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator