Repository navigation
test_runner: filter execArgv fallback for child tests - #64056
Merged
nodejs-github-bot merged 1 commit intoJun 29, 2026
Merged
Conversation
Collaborator
|
Review requested:
|
panva
approved these changes
Jun 22, 2026
trivikr
force-pushed
the
test-runner-flag-propagation
branch
from
June 22, 2026 06:36
72be9b2 to
cf6afe3
Compare
trivikr
force-pushed
the
test-runner-flag-propagation
branch
from
June 22, 2026 06:38
cf6afe3 to
4735216
Compare
Apply the test runner propagation filter to execArgv entries that are not reported by the options binding. This prevents config-file and test-runner flags from leaking into isolated child tests while still preserving V8 flags. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
trivikr
force-pushed
the
test-runner-flag-propagation
branch
from
June 22, 2026 06:44
4735216 to
456353e
Compare
Collaborator
Fixes flaky failures in
parallel/test-runner-flag-propagation.Apply the test runner propagation filter to
process.execArgventries thatare not reported by the options binding.
Some flags, such as config-file/test-runner flags, can reach the isolated
child test fallback path through
process.execArgv. Without filtering thatpath, flags like
--experimental-config-filemay leak into child tests andre-enable options that should not propagate, including
--experimental-test-coverage.This change keeps preserving V8-only flags such as
--allow-natives-syntax,while filtering test-runner control flags consistently across both
option-binding flags and fallback
execArgventries.Refs: https://github.com/nodejs/reliability/issues?q=%22test-runner-flag-propagation%22
Example
Assisted-by: openai:gpt-5.5